Remove the document argument from the clipboard helper APIs

RESOLVED FIXED in Firefox 41

Status

()

Core
Widget
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: poiru)

Tracking

unspecified
mozilla41
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
This is no longer necessary after bug 815952 was fixed.  (See bug 965199 comment 14.)

poiru, is this something that may interest you?
Flags: needinfo?(birunthan)
(Assignee)

Comment 1

3 years ago
Sure, can do.
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Flags: needinfo?(birunthan)
(Assignee)

Comment 2

3 years ago
Created attachment 8609181 [details] [diff] [review]
Remove unused document argument in uses of nsIClipboardHelper.copyString
Attachment #8609181 - Flags: review?(ehsan)
(Assignee)

Comment 3

3 years ago
Created attachment 8609183 [details] [diff] [review]
Remove SpecialPowers.copyString in place of SpecialPowers.clipboardCopyString
Attachment #8609183 - Flags: review?(ehsan)
(Assignee)

Comment 4

3 years ago
Created attachment 8609184 [details] [diff] [review]
Remove document argument from nsIClipboardHelper.copyString{,ToClipboard}
Attachment #8609184 - Flags: review?(ehsan)

Updated

3 years ago
Blocks: 965199

Comment 5

3 years ago
(Adding this bug as a dependency for Bug 965199. I modified/added some calls to clipboardHelper copyString, and will update them when this fix is merged)
(Reporter)

Updated

3 years ago
Attachment #8609181 - Flags: review?(ehsan) → review+
(Reporter)

Updated

3 years ago
Attachment #8609183 - Flags: review?(ehsan) → review+
(Reporter)

Comment 6

3 years ago
Comment on attachment 8609184 [details] [diff] [review]
Remove document argument from nsIClipboardHelper.copyString{,ToClipboard}

Review of attachment 8609184 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: layout/base/nsDocumentViewer.cpp
@@ +2642,5 @@
>    nsCOMPtr<nsIClipboardHelper> clipboard(do_GetService("@mozilla.org/widget/clipboardhelper;1", &rv));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
>    // copy the href onto the clipboard
>    nsCOMPtr<nsIDOMDocument> doc = do_QueryInterface(mDocument);

Nit: this is now unused, please remove it!
Attachment #8609184 - Flags: review?(ehsan) → review+
(Reporter)

Comment 7

3 years ago
(In reply to Julian Descottes from comment #5)
> (Adding this bug as a dependency for Bug 965199. I modified/added some calls
> to clipboardHelper copyString, and will update them when this fix is merged)

Thanks a lot, Julian!
https://hg.mozilla.org/mozilla-central/rev/b83845e4117c
https://hg.mozilla.org/mozilla-central/rev/ec14eee472e5
https://hg.mozilla.org/mozilla-central/rev/9e89159cbe38
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41

Updated

3 years ago
Blocks: 1167952
You need to log in before you can comment on or make changes to this bug.