Closed Bug 1166840 Opened 6 years ago Closed 6 years ago

Remove the document argument from the clipboard helper APIs

Categories

(Core :: Widget, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: ehsan, Assigned: poiru)

References

Details

Attachments

(3 files)

This is no longer necessary after bug 815952 was fixed.  (See bug 965199 comment 14.)

poiru, is this something that may interest you?
Flags: needinfo?(birunthan)
Sure, can do.
Assignee: nobody → birunthan
Status: NEW → ASSIGNED
Flags: needinfo?(birunthan)
Blocks: 965199
(Adding this bug as a dependency for Bug 965199. I modified/added some calls to clipboardHelper copyString, and will update them when this fix is merged)
Attachment #8609181 - Flags: review?(ehsan) → review+
Attachment #8609183 - Flags: review?(ehsan) → review+
Comment on attachment 8609184 [details] [diff] [review]
Remove document argument from nsIClipboardHelper.copyString{,ToClipboard}

Review of attachment 8609184 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: layout/base/nsDocumentViewer.cpp
@@ +2642,5 @@
>    nsCOMPtr<nsIClipboardHelper> clipboard(do_GetService("@mozilla.org/widget/clipboardhelper;1", &rv));
>    NS_ENSURE_SUCCESS(rv, rv);
>  
>    // copy the href onto the clipboard
>    nsCOMPtr<nsIDOMDocument> doc = do_QueryInterface(mDocument);

Nit: this is now unused, please remove it!
Attachment #8609184 - Flags: review?(ehsan) → review+
(In reply to Julian Descottes from comment #5)
> (Adding this bug as a dependency for Bug 965199. I modified/added some calls
> to clipboardHelper copyString, and will update them when this fix is merged)

Thanks a lot, Julian!
Blocks: 1167952
You need to log in before you can comment on or make changes to this bug.