Closed Bug 1166842 Opened 5 years ago Closed 5 years ago

Re-enable binary extensions for comm-central

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(thunderbird40 fixed, thunderbird41 fixed, thunderbird_esr38 unaffected, seamonkey2.37 fixed, seamonkey2.38 fixed)

RESOLVED FIXED
Thunderbird 41.0
Tracking Status
thunderbird40 --- fixed
thunderbird41 --- fixed
thunderbird_esr38 --- unaffected
seamonkey2.37 --- fixed
seamonkey2.38 --- fixed

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(1 file)

No description provided.
Attached patch Fix - v1 β€” β€” Splinter Review
Here is the patch to enable it, the m-c patch should be landing once inbound is open again. Callek, putting you down for review for both suite and mail.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8608257 - Flags: review?(florian)
Attachment #8608257 - Flags: review?(bugspam.Callek)
Comment on attachment 8608257 [details] [diff] [review]
Fix - v1

also consider this a=me for suite/ CLOSED TREE landing for any branch this goes to land on.
Attachment #8608257 - Flags: review?(bugspam.Callek) → review+
Attachment #8608257 - Flags: review?(florian) → review+
https://hg.mozilla.org/comm-central/rev/c64485a52e46
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
https://hg.mozilla.org/releases/comm-aurora/rev/0044a2a29280
Target Milestone: Thunderbird 41.0 → Thunderbird 40.0
My understanding is that the "Target Milestone" field shows when the bug was first landed, and is not updated after uplifts.
Fine with me, I handle this different in Calendar where we don't use tracking flags.
Target Milestone: Thunderbird 40.0 → Thunderbird 41.0
(In reply to Kent James (:rkent) from comment #5)
> My understanding is that the "Target Milestone" field shows when the bug was
> first landed, and is not updated after uplifts.

Yes, that's the reason that there are separate tracking flags. Strictly speaking, this bug isn't fixed for Thunderbird 40.0 and SeaMonkey 2.37 yet given that bug 1165428 hasn't landed on mozilla-aurora so far (or, at least, it's not visible/effective on aurora builds yet).
(In reply to Philipp Kewisch [:Fallen] from comment #3)
> https://hg.mozilla.org/comm-central/rev/c64485a52e46

(In reply to Philipp Kewisch [:Fallen] from comment #4)
> https://hg.mozilla.org/releases/comm-aurora/rev/0044a2a29280

These are the wrong changesets, by the way (those were for bug 1163306).
For the record, here the actual changesets:

https://hg.mozilla.org/comm-central/rev/3318e9799d45
https://hg.mozilla.org/releases/comm-aurora/rev/857f3791ddf8
You need to log in before you can comment on or make changes to this bug.