Closed
Bug 1166846
Opened 9 years ago
Closed 9 years ago
[System] Convert string.contains to string.includes
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S13 (29may)
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
W/GeckoConsole( 2527): [JavaScript Warning: "String.prototype.contains() is deprecated and will be removed in a future release; use String.prototype.includes() instead" {file: "app://system.gaiamobile.org/js/software_button_manager.js" line: 104}]
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8608263 [details] [review] [gaia] KevinGrandon:bug_1166846_shb_string_includes > mozilla-b2g:master R=me as this is only a function renaming and want to save on review cycles.
Attachment #8608263 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Summary: [software_button_manager] Convert string.contains to string.includes → Convert string.contains to string.includes
Assignee | ||
Updated•9 years ago
|
Summary: Convert string.contains to string.includes → [System] Convert string.contains to string.includes
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d3d9e553628b11ebf326e63e757492383609a40a
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S13 (29may)
You need to log in
before you can comment on or make changes to this bug.
Description
•