1166863 - [Messages] Convert string.contains to string.includes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Kevin Grandon :kgrandon]

Seeing errors like: 

JavaScript warning: JavaScript warning: app://communications.gaiamobile.org/dialer/test/unit/dialer_test.js?time=1432147671966, line 750: String.prototype.contains() is deprecated and will be removed in a future release; use String.prototype.includes() instead

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1166863_messages_string_includes > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8608276 [details] [review]
[gaia] KevinGrandon:bug_1166863_messages_string_includes > mozilla-b2g:master

Oleg or Steve - would either one of you have time for a review?

Comment 3

[Oleg Zasypkin [:azasypkin]]

Thanks for the fix! We have contributor that wanted to work on the dupe of this bug (bug 1161530).

Let me check if he's still working on this :)

Comment 4

[Steve Chung [:steveck]]

Comment on attachment 8608276 [details] [review]
[gaia] KevinGrandon:bug_1166863_messages_string_includes > mozilla-b2g:master

LGTM if bug 1161530 didn't have any progress yet, thanks!

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8608276 [details] [review]
[gaia] KevinGrandon:bug_1166863_messages_string_includes > mozilla-b2g:master

Thanks.. Let's give the contributor a few days in bug 1161530 to see if they want to land a patch. If not we can land this.

Comment 7

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8608276 [details] [review]
[gaia] KevinGrandon:bug_1166863_messages_string_includes > mozilla-b2g:master

Okay, contributor haven't started to work on this bug yet, so let's land it!

Comment 8

[Kevin Grandon :kgrandon]

Ah, sorry for taking the easy/contributor bug. Will mind that in the future.

Comment 9

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#my3gazQuQnWYMM_w-yUb7g

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 10

[Kevin Grandon :kgrandon]

Tree closure might be having some weird effect on autolander. Let's try this again.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/6fa6da150c71a18a274da87a06b1c88e7b7db33f