1166873 - Pin treeherder-client to 1.0 in requirements.txt

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

From the irc log:
20:08 davehunt: mwargers: that treeherder failure has been happening for almost three weeks!
20:09 davehunt: looks like it lines up with a change to the treeherder client, 1.2 was released at that time: https://pypi.python.org/pypi/treeherder-client/1.2
20:10 davehunt: wlach: looks like a treeherder client release broke gaiatest
20:10 wlach: davehunt: hmm
20:10 davehunt: something not backwards compatible?
20:11 wlach: davehunt: possibly... I think camd modified it recently to return request objects. we also have some other breaking changes in the pipeline
20:11 wlach: davehunt: are you not pinning?
20:11 davehunt: mwargers: we should probably pin to 1.1 in here: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/requirements.txt#L7
20:11 davehunt: wlach: no, but we should :)
20:11 wlach: davehunt: yeah, just do that for now
20:11 davehunt: especially as it's become active again :)
20:11 wlach: davehunt: then you can update for the changes we're making at your leisure
20:12 davehunt: mwargers: would you mind taking that?

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/requirements.txt#L7

Comment 1

[Martijn Wargers (dead)]

This would fix the failures seen in:
http://jenkins1.qa.scl3.mozilla.com/view/Mozilla%20Lab/job/flame-kk-319.b2g-inbound.tinderbox.ui.functional.sanity/lastCompletedBuild/testReport/
http://jenkins1.qa.scl3.mozilla.com/view/Mozilla%20Lab/job/flame-kk-319.b2g-inbound.tinderbox.ui.functional.sanity/lastCompletedBuild/console
There was an issue posting results to Treeherder, likely causing us not to write the xunit report.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1166873 > mozilla-b2g:master

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8608287 [details] [review]
[gaia] mwargers:1166873 > mozilla-b2g:master

Like this, I assume?

Comment 4

[Martijn Wargers (dead)]

https://github.com/mozilla-b2g/gaia/commit/af37121a6f7d1b7b1e91288658da53e97b7dc3ac

Comment 5

[Carsten Book [:Tomcat]]

had to revert this for breaking tests like https://treeherder.mozilla.org/logviewer.html#?job_id=1984495&repo=b2g-inbound

Comment 6

[Martijn Wargers (dead)]

Sorry about that!
Treeherder try didn't show any errors in the Gaia UI tests or MarionetteJS tests.
I would have thought this only influenced the Gaia UI tests, but apparently not.

Dave Hunt, what needs to be done here to get this working without breaking b2g-inbound?

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I don't see how changing the treeherder-client (a python package) could influence Gij. The Gip issues are because treeherder-client 1.1 is not available at http://pypi.pub.build.mozilla.org/pub/. We could either get 1.1 pushed there, or pin to 1.0, which must be what we were using until very recently.

Comment 8

[Kevin Grandon :kgrandon]

Hmm, seems things are still failing after the backout, we're seeing errors like this: 

14:02:14     INFO -    Retrying (Retry(total=4, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', gaierror(-2, 'Name or service not known'))': /pub

Is something wrong with the pypi.pub.build.mozilla.org service?

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1166873 > mozilla-b2g:master

Comment 10

[Martijn Wargers (dead)]

Comment on attachment 8609498 [details] [review]
[gaia] mwargers:1166873 > mozilla-b2g:master

According to Dave Hunt, treeherder-client==1.0 should work.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1166873_v2 > mozilla-b2g:master

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8609498 [details] [review]
[gaia] mwargers:1166873 > mozilla-b2g:master

Please watch the build results after merging.

Comment 13

[Martijn Wargers (dead)]

(In reply to Dave Hunt (:davehunt) from comment #12)
> Comment on attachment 8609498 [details] [review]
> [gaia] mwargers:1166873 > mozilla-b2g:master
> 
> Please watch the build results after merging.

https://github.com/mozilla-b2g/gaia/commit/5bcc08a732163087999251b523e3643db397412c
*crosses fingers*

Comment 14

[Martijn Wargers (dead)]

It seems the Gip tests are running correctly on Treeherder with this pull request checked in: https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=650b26d09a24

Comment 15

[William Hsu [:whsu]]

Hi, Martijn,

May I have your help?
Can you help uplift this patch to v2.2, v2.1, and v2.1s?

Thanks.

Comment 16

[Martijn Wargers (dead)]

Hi William, I'll do this in bug 1171825.

Comment 17

[Martijn Wargers (dead)]

Oh, William is also asking for v2.1 and v2.1s versions in bug 1166873, comment 15. I'll do that.

Comment 18

[William Hsu [:whsu]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #17)
> Oh, William is also asking for v2.1 and v2.1s versions in bug 1166873,
> comment 15. I'll do that.

Thank you Martijn! :)