Closed Bug 1166887 Opened 9 years ago Closed 6 years ago

_setFaviconForWebReader is broken and unsafe

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: mak, Unassigned)

References

Details

_setFaviconForWebReader is currently building a /favicon.ico for supported rss web readers, for whatever reason that just doesn't work, we show a generic rss icon for any Web reader.

Moreover we can't safely load these icons from the network cause we can't build a principal.

So the simplest thing is to remove the part that is trying to fetch and set the icon, just put any other needed code in the caller point.
this code has gone and apparently we don't show icons anymore.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.