Closed
Bug 1166960
Opened 9 years ago
Closed 9 years ago
Remove redundant call to UnlockPointer
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(1 file, 1 obsolete file)
|
4.17 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently, there are two calls to UnlockPointer in nsDocument::RequestFullScreen. According to the comment, they are redundant, and can be merged.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8608376 -
Flags: review?(bugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8608376 [details] [diff] [review] patch So this changes the behavior in case pointerLockedElement is some other document than this - for example in some other window. The comment looks wrong to me.
Attachment #8608376 -
Flags: review?(bugs) → review-
|
|
Assignee | |
Updated•9 years ago
|
Summary: Remove redundant call to UnlockPointer in nsDocument::RequestFullScreen → Remove redundant call to UnlockPointer
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8608376 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8615772 [details] [diff] [review] patch It's June 8 :) Hopefully you are fine to have new review request now.
Attachment #8615772 -
Flags: review?(bugs)
|
|
||
Updated•9 years ago
|
Attachment #8615772 -
Flags: review?(bugs) → review+
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/553615c0705e
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•