Remove redundant call to UnlockPointer

RESOLVED FIXED in Firefox 41

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Currently, there are two calls to UnlockPointer in nsDocument::RequestFullScreen. According to the comment, they are redundant, and can be merged.
Created attachment 8608376 [details] [diff] [review]
patch
Attachment #8608376 - Flags: review?(bugs)

Comment 2

3 years ago
Comment on attachment 8608376 [details] [diff] [review]
patch

So this changes the behavior in case pointerLockedElement is some other document than this - for example in some other window.
The comment looks wrong to me.
Attachment #8608376 - Flags: review?(bugs) → review-
Summary: Remove redundant call to UnlockPointer in nsDocument::RequestFullScreen → Remove redundant call to UnlockPointer
Created attachment 8615772 [details] [diff] [review]
patch
Attachment #8608376 - Attachment is obsolete: true
Comment on attachment 8615772 [details] [diff] [review]
patch

It's June 8 :)

Hopefully you are fine to have new review request now.
Attachment #8615772 - Flags: review?(bugs)

Updated

3 years ago
Attachment #8615772 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/553615c0705e
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.