Open Bug 1166980 Opened 9 years ago Updated 2 years ago

Disable the Terminator during tests

Categories

(Toolkit :: Async Tooling, defect)

defect

Tracking

()

Tracking Status
firefox41 --- affected

People

(Reporter: mccr8, Unassigned)

Details

Attachments

(1 file)

I'm running a special build that is very slow, and I keep hitting the nsTerminator on shutdown, which is annoying.  It would be nice if I could just disable this without having to dig around in the source code.
Though in this particular case, maybe it is actually just hung. :)
We can certainly add a preference.
Note that you can already set "toolkit.asyncshutdown.crash_timeout" to an insanely long value to that effect.
Messing around with prefs is a little annoying, but I guess that's okay. It would be nice if there was a comment that mentions the pref in the code right next to the crash in the terminator, so when you go looking for why your code crashed, it is right there.
Sure, I can add that to the code.
Messing around with prefs is how we do this kind of things in most of the code. Do you see a better alternative?
Nah, the existing thing is fine. It would just be nice for it to be easier to figure out though a comment in the code or something.
Well,
Assignee: nobody → dteller
Component: General → Async Tooling
Product: Core → Toolkit
Summary: Add a way to disable the shutdown hang crasher → Disable the Terminator during tests
Well, apparently, it causes other issues, as discussed in bug 1121145 comment 568 so I'll do it.
Please add a comment to where the actual crash occurs, or at the top of the file where the crash happens, that says something like "To disable the terminator to set toolkit.asyncshutdown.crash_timeout to -1.", so people don't have to dig through the entire file to figure that out. Thanks.
Not working on it atm, feel free to steal.
Assignee: dteller → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: