1166980 - Disable the Terminator during tests

Status: NEW

(Toolkit :: Async Tooling, defect)

Description

[Andrew McCreight [:mccr8]]

I'm running a special build that is very slow, and I keep hitting the nsTerminator on shutdown, which is annoying.  It would be nice if I could just disable this without having to dig around in the source code.

Comment 1

[Andrew McCreight [:mccr8]]

Though in this particular case, maybe it is actually just hung. :)

Comment 2

[David Teller [:Yoric] - still alive but not very active]

We can certainly add a preference.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Note that you can already set "toolkit.asyncshutdown.crash_timeout" to an insanely long value to that effect.

Comment 4

[Andrew McCreight [:mccr8]]

Messing around with prefs is a little annoying, but I guess that's okay. It would be nice if there was a comment that mentions the pref in the code right next to the crash in the terminator, so when you go looking for why your code crashed, it is right there.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Sure, I can add that to the code.
Messing around with prefs is how we do this kind of things in most of the code. Do you see a better alternative?

Comment 6

[Andrew McCreight [:mccr8]]

Nah, the existing thing is fine. It would just be nice for it to be easier to figure out though a comment in the code or something.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Well,

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Well, apparently, it causes other issues, as discussed in bug 1121145 comment 568 so I'll do it.

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: Bug 1166980 - Disable the Terminator during tests;r=ted

Bug 1166980 - Disable the Terminator during tests;r=ted

Comment 10

[Andrew McCreight [:mccr8]]

Please add a comment to where the actual crash occurs, or at the top of the file where the crash happens, that says something like "To disable the terminator to set toolkit.asyncshutdown.crash_timeout to -1.", so people don't have to dig through the entire file to figure that out. Thanks.

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Not working on it atm, feel free to steal.