1166984 - I think Taskcluster jobs' "Inspect Task" link should still be in the left panel, not the Job Details tab

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think it should stay in the left pane, closer (and without needing any unnecessary extra clicks) to the buttons for the logviewer links.

Comment 1

[Jonathan French (:jfrench)]

If other Sheriffs are in agreement, should we also the default height of the main job panel slightly taller(?), so this added Inspect Task entry isn't clipped off the bottom of the bottom left pane (and then requires equivalent effort to view it).

I believe in some cases this change will also result in an empty Job Details tab, where afaik currently we always had something populating it. So we may need to add a "Job Details empty" tab message or similar.

Comment 2

[William Lachance (:wlach)]

I think we need to be careful about just polling the sheriffs on this-- we added the job details panel because the stuff on the left side wasn't discoverable enough to other users of treeherder.

I'm fine with just including the information in two different places fwiw. I don't think that hurts.

Comment 3

[Jonathan French (:jfrench)]

Couple of options perhaps:
a) conditionally provide a 'task' icon in the navbar eg. beside the current Log icon, if the job is a taskcluster job? The navbar UI might bounce around a lot though when traversing buildbot and tc jobs.

b) perhaps a more minimal "task" text link in the bottom left details, similar and adjacent to our 'sig'-nature link. So we don't consume another full line.

Comment 4

[Jonathan French (:jfrench)]

I think we'll go with a regular line entry below the Log parsing status for now in Job details panel. Based on discussions with Wes, sheriffs run at sufficient screen res systems the default 35% height for info panel will accommodate the extra line.

Comment 5

[Jonathan French (:jfrench)]

Attachment: PR 755

Please see above PR for status/review.

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8633475 [details] [review]
PR 755

lgtm

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9230572e17bfdaa169f7234adaa8859411c6947f
Bug 1166984 - Provide inspect-task link in Job details panel

Comment 8

[Jonathan French (:jfrench)]

Marking fixed per above merge. Will verify on the next push to stage/prod.

Comment 9

[Jonathan French (:jfrench)]

Verified fixed on stage.