1167008 - [traceback] TemplateDoesNotExist: motidings/unsubscribe_error.html

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P1)

Description

[Michael Cooper [:mythmon]]

It looks like we need to copy another template from tidings. motidings is something we made for the 1.7 upgrade, iirc.

Errormill: https://errormill.mozilla.org/support/support/group/397087/

TemplateDoesNotExist: motidings/unsubscribe_error.html

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 497, in wrapper
    return wrapped(*args, **kwargs)
  File "kitsune/motidings/views.py", line 30, in unsubscribe
    return render(request, 'motidings/unsubscribe_error.html')
  File "django/shortcuts.py", line 50, in render
    return HttpResponse(loader.render_to_string(*args, **kwargs),
  File "django/template/loader.py", line 170, in render_to_string
    t = get_template(template_name, dirs)
  File "django/template/loader.py", line 144, in get_template
    template, origin = find_template(template_name, dirs)
  File "django/template/loader.py", line 136, in find_template
    raise TemplateDoesNotExist(name)

Comment 1

[Michael Cooper [:mythmon]]

It should be pretty easy to create a new template.

Comment 2

[Michael Cooper [:mythmon]]

This is causing site errors for users when they try to unsubscribe. That makes it a P1. Putting it in the next sprint.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'll grab this.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is related:

https://errormill.mozilla.org/support/support/group/397070/

Seems like we're missing both the unsubscribe_error.html and unsubscribe_success.html templates.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/kitsune/pull/2570

I also added tests for all the various situations in that view figuring it's nice to have tests.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/kitsune/commit/dc7965ec3d73a2cd9cb1707db987dfcbf70266a2

It'll get pushed out whenever things go.

Comment 7

[Rehan Dalal (Inactive)]

Pushed to prod by me, right now.