Open Bug 116702 Opened 18 years ago Updated 10 months ago

no alert when can't connect to LDAP directory server from addressbook

Categories

(MailNews Core :: Address Book, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: sspitzer, Unassigned)

References

Details

(Keywords: student-project, Whiteboard: [patchlove][has draft patch])

Attachments

(1 file, 1 obsolete file)

no alert when can't connect to LDAP directory server from addressbook

we just silently fail.
QA Contact: nbaca → yulian
Status: NEW → ASSIGNED
Keywords: nsbeta1+
Priority: -- → P1
Target Milestone: --- → mozilla0.9.9
Whiteboard: nab-ldap
no "add directory" in address book file menu, so no access to LDAP directories?
no "add directory" in address book file menu, so no access to LDAP directories?
Priority: P1 → P2
Target Milestone: mozilla0.9.9 → mozilla1.0
ADT needs info: Does this happen in auto-complete address widget in mail
compose?  Is there any indication of failure other than an alert?  cc jglick for
UE input.
Blocks: 122274
Keywords: nsbeta1+nsbeta1
Whiteboard: nab-ldap → nab-ldap [need info]
removing milestone until we have the information and this bug is retriaged.
Target Milestone: mozilla1.0 → ---
The autocomplete widget is working correctly; this problem only effects the
addressbook.
In the AB, or Advanced AB Search, if a directory is selected and the user tries 
to use Quick Search or perform a search, and the ldap dir can not be reach, we 
should display text to that fact in the Card Pane/Results area.

"Unable to connect to the LDAP directory <name>."  or "Unable to connect to the 
LDAP directory <name>. Try again later or verify your settings for this 
directory are correct." Robin, that ok?
Seems like the real problem is that, unlike Netscape 4.7x, "add a 
(LDAP)directory" isn't even an option in address book. So I'm not even sure 
people can try to connect to an LDAP directory. Maybe this wasn't really a 
duplicate bug.
>Seems like the real problem is that, unlike Netscape 4.7x, "add a 
>(LDAP)directory" isn't even an option in address book.

It should be shortly.
Suggested error text: "Unable to connect to the LDAP directory <name>. Verify
that your settings for this directory are correct or else try again later."

thanks robin. :-)
How about using the ldapErrors.properties stringbundle for this?  It contains
all the error messages that robinf and I concocted for handling LDAP
autocomplete errors.
Discussed in 2/27/02 Mail & News bug meeting.  Decisions was to plus this bug.
Keywords: nsbeta1nsbeta1+
Target Milestone: --- → mozilla1.0
Discussed (again) in Mail News bug meeting.  Decision was to minus and move to 1.2.
Keywords: nsbeta1+nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2
*** Bug 124555 has been marked as a duplicate of this bug. ***
*** Bug 150719 has been marked as a duplicate of this bug. ***
OS: Windows 2000 → All
Hardware: PC → All
Blocks: 156960
Keywords: nsbeta1-nsbeta1
Whiteboard: nab-ldap [need info] → nab-ldap [need info][ue2]
QA Contact: yulian → gchan
we don't display an error mesg when searching ldap server in addressbook.

If we do typedown addressing in the compose window we do display an error.
Mail triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: nab-ldap [need info][ue2] → [adt3] nab-ldap [ue2]
Reassigning.
Assignee: sspitzer → cavin
Status: ASSIGNED → NEW
Target Milestone: mozilla1.2alpha → mozilla1.4beta
Since we know the error code so it's better if we can also put out the error
reason. Something like:

LDAP Server Connection Failed  (this is the dialog title)

 Unable to connect to the LDAP directory <name>. Verify that your 
 settings for this directory are correct or else try again later.

 Reason: Can't connect to the LDAP server.

Robin, please comment.
Attached patch Proposed patch, v1 (obsolete) — Splinter Review
Will change wording when receiving comments.
+unableToConnect=Unable to connect to the LDAP directory %S. Verify that your
settings for this directory are correct or else try again later.\n\nReason: %S.

r=robinf. Please also get approval from bobj, since this has L10N impact.
Ccing Bob.
Attachment #123166 - Flags: superreview?(sspitzer)
taking from cavin, I'll test/review/drive this in.

might slip to 1.5, though.
Whiteboard: [adt3] nab-ldap [ue2] → [adt3] nab-ldap [ue2] [patch]
Target Milestone: mozilla1.4beta → mozilla1.4final
send over to david (and cc scott) as this is something enterprise users might want.
Assignee: cavin → bienvenu
Product: Browser → Seamonkey
dan/david: do we still want this, or is it going to get in the way?
I think we very much want a fix for this bug.  There are two problems with the
existing patch: one is that it only seems to notice errors that happen in the
nsLDAPOperation stub methods, which is likely to be a tiny tiny minority of the
LDAP errors that are likely to actually happen.  The second is that it just
converts everything to a single generic message, rather than exposing the
underlying LDAP error message, which is what nsLDAPAutoCompleteSession and
friends do, and is much more useful.

That said, the existing patch offers slightly better behavior than the current
state of affairs, which is complete silence all the time.
*** Bug 256310 has been marked as a duplicate of this bug. ***
Component: Address Book → MailNews: Address Book
Product: Mozilla Application Suite → Core
Target Milestone: mozilla1.4final → ---
over to Standard8 for consideration...
Assignee: bienvenu → bugzilla
Comment on attachment 123166 [details] [diff] [review]
Proposed patch, v1

Well this isn't going to apply, so cancelling the review request.

I think we want to fix this in a good way, as Dan suggested. I'll try and take a look at it again before TB 3.
Attachment #123166 - Flags: superreview?(sspitzer)
Flags: wanted-thunderbird3+
QA Contact: grylchan → addressbook
Product: Core → MailNews Core
Target Milestone: --- → Thunderbird 3.0b2
Priority: P2 → P3
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
Whiteboard: [adt3] nab-ldap [ue2] [patch] → nab-ldap
We want this, but I'm not going to work on it at the moment. Rather than an alert, some non-intrusive UI indication may be better though.
Assignee: bugzilla → nobody
Keywords: student-project
Priority: P3 → --
Target Milestone: Thunderbird 3.0b2 → ---
xref Bug 103426 Mail address auto complete yields error message "LDAP server search problem" if LDAP server incorrect
Whiteboard: nab-ldap → [patchlove][has draft patch]
Comment on attachment 123166 [details] [diff] [review]
Proposed patch, v1

Comment 29 has indicated this will not apply and might not be the best way forward..
Attachment #123166 - Attachment is obsolete: true
See Also: → tb-logging
You need to log in before you can comment on or make changes to this bug.