116702 - no alert when can't connect to LDAP directory server from addressbook

Status: NEW

(MailNews Core :: Address Book, defect)

Description

[(not reading, please use [e-mail] instead)]

no alert when can't connect to LDAP directory server from addressbook

we just silently fail.

Comment 1

[Blake Learmonth]

no "add directory" in address book file menu, so no access to LDAP directories?

Comment 2

[Blake Learmonth]

no "add directory" in address book file menu, so no access to LDAP directories?

Comment 3

[Peter Trudelle]

ADT needs info: Does this happen in auto-complete address widget in mail
compose?  Is there any indication of failure other than an alert?  cc jglick for
UE input.

Comment 4

[scottputterman]

removing milestone until we have the information and this bug is retriaged.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

The autocomplete widget is working correctly; this problem only effects the
addressbook.

Comment 6

[jglick]

In the AB, or Advanced AB Search, if a directory is selected and the user tries 
to use Quick Search or perform a search, and the ldap dir can not be reach, we 
should display text to that fact in the Card Pane/Results area.

"Unable to connect to the LDAP directory <name>."  or "Unable to connect to the 
LDAP directory <name>. Try again later or verify your settings for this 
directory are correct." Robin, that ok?

Comment 7

[Blake Learmonth]

Seems like the real problem is that, unlike Netscape 4.7x, "add a 
(LDAP)directory" isn't even an option in address book. So I'm not even sure 
people can try to connect to an LDAP directory. Maybe this wasn't really a 
duplicate bug.

Comment 8

[jglick]

>Seems like the real problem is that, unlike Netscape 4.7x, "add a 
>(LDAP)directory" isn't even an option in address book.

It should be shortly.

Comment 9

[robinf]

Suggested error text: "Unable to connect to the LDAP directory <name>. Verify
that your settings for this directory are correct or else try again later."

Comment 10

[jglick]

thanks robin. :-)

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

How about using the ldapErrors.properties stringbundle for this?  It contains
all the error messages that robinf and I concocted for handling LDAP
autocomplete errors.

Comment 12

[Michael Buckland]

Discussed in 2/27/02 Mail & News bug meeting.  Decisions was to plus this bug.

Comment 13

[Michael Buckland]

Discussed (again) in Mail News bug meeting.  Decision was to minus and move to 1.2.

Comment 14

[Dan Mosedale (:dmosedale, :dmose)]

*** Bug 124555 has been marked as a duplicate of this bug. ***

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

*** Bug 150719 has been marked as a duplicate of this bug. ***

Comment 16

[grylchan]

Attachment: screen shot of ldap error in the compose window

we don't display an error mesg when searching ldap server in addressbook.

If we do typedown addressing in the compose window we do display an error.

Comment 17

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 18

[Cavin Song]

Reassigning.

Comment 19

[Cavin Song]

Since we know the error code so it's better if we can also put out the error
reason. Something like:

LDAP Server Connection Failed  (this is the dialog title)

 Unable to connect to the LDAP directory <name>. Verify that your 
 settings for this directory are correct or else try again later.

 Reason: Can't connect to the LDAP server.

Robin, please comment.

Comment 20

[Cavin Song]

Attachment: Proposed patch, v1

Will change wording when receiving comments.

Comment 21

[robinf]

+unableToConnect=Unable to connect to the LDAP directory %S. Verify that your
settings for this directory are correct or else try again later.\n\nReason: %S.

r=robinf. Please also get approval from bobj, since this has L10N impact.

Comment 22

[Cavin Song]

Ccing Bob.

Comment 23

[(not reading, please use [e-mail] instead)]

taking from cavin, I'll test/review/drive this in.

might slip to 1.5, though.

Comment 24

[(not reading, please use [e-mail] instead)]

send over to david (and cc scott) as this is something enterprise users might want.

Comment 25

[Mark Banner (:standard8)]

dan/david: do we still want this, or is it going to get in the way?

Comment 26

[Dan Mosedale (:dmosedale, :dmose)]

I think we very much want a fix for this bug.  There are two problems with the
existing patch: one is that it only seems to notice errors that happen in the
nsLDAPOperation stub methods, which is likely to be a tiny tiny minority of the
LDAP errors that are likely to actually happen.  The second is that it just
converts everything to a single generic message, rather than exposing the
underlying LDAP error message, which is what nsLDAPAutoCompleteSession and
friends do, and is much more useful.

That said, the existing patch offers slightly better behavior than the current
state of affairs, which is complete silence all the time.

Comment 27

[Mark Banner (:standard8)]

*** Bug 256310 has been marked as a duplicate of this bug. ***

Comment 28

[David :Bienvenu]

over to Standard8 for consideration...

Comment 29

[Mark Banner (:standard8)]

Comment on attachment 123166 [details] [diff] [review]
Proposed patch, v1

Well this isn't going to apply, so cancelling the review request.

I think we want to fix this in a good way, as Dan suggested. I'll try and take a look at it again before TB 3.

Comment 30

[Mark Banner (:standard8)]

We want this, but I'm not going to work on it at the moment. Rather than an alert, some non-intrusive UI indication may be better though.

Comment 31

[Wayne Mery (:wsmwk)]

xref Bug 103426 Mail address auto complete yields error message "LDAP server search problem" if LDAP server incorrect

Comment 32

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 123166 [details] [diff] [review]
Proposed patch, v1

Comment 29 has indicated this will not apply and might not be the best way forward..