1167021 - Call Tree total cost > 100%, total time > duration in non-inverted

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: Screen Shot 2015-05-20 at 7.53.26 PM.png

See screenshot

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: totalcostweird.json

recording data to reproduce

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

One issue here is the profiler data is longer than timeline data by a second or so, so different results when nothing selected vs the entire graph selected.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

More info on recreating this in bug 1172229 -- due to recursion where a frame called multiple times in a sample is counted several times, increasing its total cost > total duration.

Possibly related to bug 1164325, which may be the same thing here.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

I think bug 1177293 fixed this -- but should add tests for this, (and bug 1177293) to ensure that.

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1167021-tree-model-cost.patch

Pulls out the cost logic into the model, rather than in the view, and add more tests for recursion and cost calculation -- covers the scenario in bug 1177239 as well with a test.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0bd780427d2

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 8633705 [details] [diff] [review]
1167021-tree-model-cost.patch

Review of attachment 8633705 [details] [diff] [review]:
-----------------------------------------------------------------

Very cool, I wanted to do this too.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d2daa6751884

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d2daa6751884