1167063 - Fail to boot-up if an app manifest contains 'widgetPages'.

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Sherman Chen [:chens] (inactive)]

+++ This bug was initially created as a clone of Bug #1164341 +++

We will get `JavaScript error: resource://gre/modules/AppsServiceChild.jsm, line 10: TypeError: list is undefined` when `widgetPages` exist in app mainfest, it will hang at mozilla logo and can't bootup properly.

Comment 1

[Sherman Chen [:chens] (inactive)]

Junior, I'm not sure which component it should belong, and could you help on it? thanks.

Comment 2

[Sherman Chen [:chens] (inactive)]

It could reproduce on b2g-desktop with tv build, try `make clean && make GAIA_DEVCE_TYPE=tv && b2g/b2g-bin -profile profile` to reproduce this.

Comment 3

[Junior [inactive]]

I found two wired facts addressed below:

1. In a |sendSyncMessage|, the return value is an object in |receiveMessage|:
https://dxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.jsm#1360
But get an empty array as a return value.
https://dxr.mozilla.org/mozilla-central/source/dom/apps/AppsServiceChild.jsm#117

2. |widgetPages| of |this.webapps| in webapps.jsm looks wired:

"widgetPages":[{"spec":"app://xxx.gaiamobile.org/widget.html","prePath":"app://xxx.gaiamobile.org","scheme":"app","userPass":"","username":"","password":"","hostPort":"xxx.gaiamobile.org","host":"xxx.gaiamobile.org","port":-1,"path":"/widget.html","asciiSpec":"app://xxx.gaiamobile.org/widget.html","asciiHost":"xxx.gaiamobile.org","originCharset":"UTF-8","ref":"","specIgnoringRef":"app://xxx.gaiamobile.org/widget.html","hasRef":false}]

That is not what I expect. Seems it's kinda |nsIURI| instead of a string.

Comment 4

[Junior [inactive]]

Okay, |this.webapps.aApp.widgetPages| stores an array of |nsIURI|s for speedup.
However, |sendSyncMessage| could not allow to get |nsIURI| even if |nsIURI| is scriptable.

(I did experiments to substitute string for |nsIURI| and it can pass |sendSyncMessage|)

Comment 5

[Junior [inactive]]

Since we need to use widgetPages in both parent and child process. We still need a way to sync widgetPages between Webapps.jsm and AppsServiceChild.jsm

Comment 6

[Junior [inactive]]

Attachment: fail-to-boot-up-for-widgets

Simply use string instead of nsIURI to avoid |sendSyncMessage(nsIURI)|

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4da14771a327

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/2bd139a86f1b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2bd139a86f1b