1167070 - Overwrite BLE related flags to enable BLE functionalities in bluedroid for both bluetooth1 and bluetooth2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jocelyn Liu [:jocelyn] [:joliu]]

Currently bluetooth1 and bluetooth2 share the same b2g_bdroid_buildcfg.h under bluetooth/bluedroid, and BLE related flags are overwritten manually by developers who wants to use bluetooth2 with GATT API.

After several test rounds done by QA and bluetooth team members, we didn't see any side effect on classic bluetooth functions caused by enabling BLE functionalities in bluedroid.

IMHO, we're ready to enable BLE functionalities in bluedroid for both bluetooth1 and bluetooth2 now.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

I'd suggest to move this header file into bluetoothd's repository.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #1)
> I'd suggest to move this header file into bluetoothd's repository.

OK, that's actually a different bug. We discussed this a bit on IRC and it's something we want to do after having moved away from HAL.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1167070: Overwrite BLE related flags to enable BLE functionalities in bluedroid for both bluetooth1 and bluetooth2.

Hi Shawn,

Could you help to review my patch.

Thanks,
Jocelyn

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

\0/

Comment 5

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1167070: Overwrite BLE related flags to enable BLE functionalities in bluedroid for both bluetooth1 and bluetooth2. r=shuang

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27eb8326899d

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/4fbe8dbf3a35

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4fbe8dbf3a35