1167072 - Set up font.name/name-list preferences for gfx.font_rendering.fontconfig.fontlist.enabled

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Karl Tomlinson (:karlt)]

gfxPlatform::ForEachPrefFont() and so
gfx.font_rendering.fontconfig.fontlist.enabled depends on
font.{name|name-list}.<generic>.<langGroup> preferences existing for each
return value of GetFontPrefLangFor() [1].  Without this, no font will be found
to support the language of the characters.

There are no preferences for langGroup = x-khmr at least.

The other groups need to be checked.

fontconfig generics should be specified in both name and name-list prefs so that there is sane fallback when font.name.* are changed through the UI.

[1] https://hg.mozilla.org/mozilla-central/annotate/8d8df22fe72d/gfx/thebes/gfxPlatform.cpp#l1457

Comment 1

[John Daggett (:jtd)]

Attachment: patch, add pref fonts for all lang groups under Linux

Fill in the missing font prefs for Linux.

Comment 2

[John Daggett (:jtd)]

tryserver build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=674c9657cc2f

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/307743e12ccc

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/307743e12ccc

Comment 5

[Thomasy]

Can we uplift the patch since without this patch the instant message is broken on Linux (bug 791926)?

Comment 6

[John Daggett (:jtd)]

(In reply to Thomasy from comment #5)
> Can we uplift the patch since without this patch the instant message is
> broken on Linux (bug 791926)?

What uplift are you referrring to? This was landed back in May and is part of FF41 so it will be the release version as of next week.

Comment 7

[Thomasy]

(In reply to John Daggett (:jtd) from comment #6)
> (In reply to Thomasy from comment #5)
> > Can we uplift the patch since without this patch the instant message is
> > broken on Linux (bug 791926)?
> 
> What uplift are you referrring to? This was landed back in May and is part
> of FF41 so it will be the release version as of next week.

Get it. In this case, it will be no need to uplift.