All users were logged out of Bugzilla on October 13th, 2018

[building block] smart-modal-dialog should line all buttons as one line.

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

smart modal dialog wraps buttons as multiple line. We should make it only one line.
Created attachment 8608624 [details] [review]
put all buttons at one line.

Sung,

Please review this patch. Thanks.
Attachment #8608624 - Flags: review?(suchiu)
Assignee: nobody → im
I will create a patch here to update the smart-system.

Comment 3

3 years ago
Comment on attachment 8608624 [details] [review]
put all buttons at one line.

This patch is great!
Attachment #8608624 - Flags: review?(suchiu) → review+
merge to smart-modal-dialog:
https://github.com/smart-components/smart-modal-dialog/pull/6

keep it opening for reminding me to create a patch for smart-system.
Created attachment 8609936 [details] [review]
[gaia] huchengtw-moz:bug-1167117-update-smart-modal-dialog > mozilla-b2g:master
Comment on attachment 8609936 [details] [review]
[gaia] huchengtw-moz:bug-1167117-update-smart-modal-dialog > mozilla-b2g:master

Since this patch is just update the bower component, I carry r+ from bower component.
Attachment #8609936 - Flags: review+
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.