1167126 - Failure in testCheckAboutPrivateBrowsing due to ''about:blank' not found in 'http://127.0.0.1:62177/private_browsing/about.html?private-browsing'"

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

This failure is only occurring on Windows. A check into the test shows me that it is using kinda outdated window handling methods. Maybe that is the cause here. I will update the test to use our current API, which also makes it way more stable. 

00:01:33.044   File "c:\jenkins\workspace\mozilla-central_functional\firefox-ui-tests\firefox_ui_tests\functional\private_browsing\test_about_private_browsing.py", line 60, in testCheckAboutPrivateBrowsing
00:01:33.044     self.assertIn(url_bar.get_attribute('value'), target_url)
00:01:33.044 AssertionError: u'about:blank' not found in 'http://127.0.0.1:62177/private_browsing/about.html?private-browsing'

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Attachment: github_pull_request.txt

This PR makes the private browsing test way more robust!

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

It looks like that the test with my patch applied is permanently failing on OS X. I will check if that is related to the accelkey usage.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

The problem here was that the Firefox UI test did a different action than the Mozmill test. We should not use the global shortcut to open the private browsing window but really interacting with the button. I pushed an update which fixes that across platform.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8608635 [details] [review]
github_pull_request.txt

overall this is great and looks better.  I have a few comments in the PR, more minor stuff that once we address them it is good to go.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

PR got merged as:
https://github.com/mozilla/firefox-ui-tests/commit/d73ed45db3157b9b6fbd70b973a0483545269da7

This changeset would need to backported to all the other branches.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

https://github.com/mozilla/firefox-ui-tests/commit/5a5a7a8625cd9139bddf239e3293a171172b2a6e (aurora)
https://github.com/mozilla/firefox-ui-tests/commit/e6bb22a9708197f274c759c09670c2d949776852 (beta)

mozilla-release and mozilla-esr38 branches got rebased against beta, so they have the same changeset.