UX Issues with Keyboard shortcuts - Firefox Developer Tools | MDN

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: anaran, Assigned: anaran)

Tracking

Details

(URL)

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
Created attachment 8608643 [details]
Maximized.png

See:

https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts

Details:

1.
The page does not render tables well in various typical window configurations, like maximized or semi-maximized (full height, half width).

The cause for this are hard-coded styles.

2.
The tables use table-header styling for the first column to make it stand out. Used in this way it does not really stand out.

3.
The first column is typically labelled with "Command" in https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly, which is probably a good target to by conform with for the extra impression of a unified design language.
This header is missing and the command column is not always phrased as a command.

I am going to tackle 1 and 3 and would like to have additional feedback on 2.


http://mzl.la/1vxCDgA
(Assignee)

Comment 1

3 years ago
Created attachment 8608648 [details]
SemiMaximized.png

Only Windows shortcut column is visibale, no table of contents.
(Assignee)

Comment 2

3 years ago
Comment on attachment 8608643 [details]
Maximized.png

Table of contents obstructs shortcut table with hard-coded styling.
(Assignee)

Comment 3

3 years ago
Comment on attachment 8608648 [details]
SemiMaximized.png

Only Windows shortcut column is visible, no table of contents.
(Assignee)

Updated

3 years ago
Assignee: nobody → adrian.aichner
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

3 years ago
I have tried my hand at items 1 and 3, had to keep minimal styling (of command column only to maintain alignment of tables.

Looking at this page for a while I think item 2 should also be implemented, but I'll wait for feedback.
(Assignee)

Comment 5

3 years ago
Created attachment 8608673 [details]
Maximized-after.png

No interference with table of contents, tables still line up
(Assignee)

Comment 6

3 years ago
Created attachment 8608674 [details]
SemiMaximized-after.png

All platform columns visible, tables still line up.
Table of contents is only shown at top, like before.
What does your changed CSS look like, assuming that's all you've changed?
(Assignee)

Comment 8

3 years ago
As discussed, we'll leave command column marked up as <th> for now (item 2 in the report).

Summary of my changes as found in revision history:

Minimize use of style attribute to Command column for maintainability while keeping tables aligned
Remove absolute size from first table, add Command header, upgrade commands to verb phrase
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.