Closed
Bug 1167176
Opened 9 years ago
Closed 9 years ago
Fatal assertion: Assertion failure: false (Only operate on BGRA8 surfs.), at gfx/thebes/gfxUtils.cpp:188 -- Opening Inspector on some WebGL containing pages causes the browser to crash
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: mahdi, Assigned: lsalzman)
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files)
21.53 KB,
text/x-log
|
Details | |
729 bytes,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:41.0) Gecko/20100101 Firefox/41.0 Build ID: 20150521020354 Steps to reproduce: This will cause your browser to crash: Open http://104.131.12.163:3000/ Open inspector The page uses these libraries: Phaser.js, System.js (to load modules), Nunjucks, Sprint.js, es6-module-loader.js, EventEmitter.js. And the source is compiled from es6 to es5 using Babel. I tested on Phaser.js and WebGL demos, neither caused my browser to crash. If the source code is needed, ask, I hope the team agrees.
Comment 1•9 years ago
|
||
Jeff, can you help here? The assertion line seems to have been introduced by you. :-)
Flags: needinfo?(jgilbert)
Summary: Opening Inspector on some WebGL containing pages causes the browser to crash → Fatal assertion: Assertion failure: false (Only operate on BGRA8 surfs.), at gfx/thebes/gfxUtils.cpp:188 -- Opening Inspector on some WebGL containing pages causes the browser to crash
Updated•9 years ago
|
Whiteboard: [gfx-noted]
Assignee | ||
Comment 2•9 years ago
|
||
I couldn't manage to run the testcase, but just eyeballing the code is enough to see how/why this is occurring. There's no point in premultiplying the snapshot if the context is not using alpha. In that case, it creates a surface of B8G8R8X8, which triggers the assertion. The sane thing to do here, thus, is not to premultiply when that is the case...
Assignee: nobody → lsalzman
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #8613169 -
Flags: review?(jgilbert)
Updated•9 years ago
|
Attachment #8613169 -
Flags: review?(jgilbert) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
can we get a try run, thanks!
Flags: needinfo?(lsalzman)
Keywords: checkin-needed
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #3) > can we get a try run, thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c39507c45ec
Flags: needinfo?(lsalzman)
Reporter | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d216678de399
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•9 years ago
|
Flags: needinfo?(jgilbert)
You need to log in
before you can comment on or make changes to this bug.
Description
•