Closed Bug 1167178 Opened 5 years ago Closed 3 years ago
The newtab option menu items are not correctly aligned in RTL builds
Reproducing using latest Nightly, build ID: 20150520030205. STR: 1. Open Firefox using a RTL locale; 2. Navigate to about:newtab; 3. Click on the cog wheel. Results: The new tab option menu item alignment is messed up. Issue on the: - He build: http://i.imgur.com/vyShObX.png - Ar build: http://i.imgur.com/s9h4mrq.png Also reproduced this using the en-US build by creating a intl.uidirection.en pref and set it's value to RTL.
Issue is a bit better than the previously supplied screenshots, but is still not fully resolved. I'm planning to look into this issue.
Assignee: nobody → tomer.moz.bugs
Attachment #8829213 - Flags: review?(msamuel) → review?(adw)
Comment on attachment 8829213 [details] Bug 1167178 - The newtab option menu items are not correctly aligned in RTL builds https://reviewboard.mozilla.org/r/106360/#review117800 Thanks very much! :-)
Attachment #8829213 - Flags: review?(adw) → review+
And sorry for the big delay.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Sorry, accidentally marked as RESOLVED FIXED.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/34dcb179266b The newtab option menu items are not correctly aligned in RTL builds r=adw
Looking good on latest Nightly.
Great, thanks again Tomer.
Reproduced the bug in firefox beta 39.0.3 (2015-08-06) with windows 10 (64 bit) Verified as fixed with latest firefox beta 54.0b7 (Build ID: 20170511130324) Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
You need to log in before you can comment on or make changes to this bug.