The newtab option menu items are not correctly aligned in RTL builds

VERIFIED FIXED in Firefox 54

Status

()

Firefox
New Tab Page
VERIFIED FIXED
2 years ago
2 months ago

People

(Reporter: cornel_ionce, Assigned: tomer)

Tracking

41 Branch
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox41 affected, firefox54 fixed)

Details

(Whiteboard: [testday-20170512], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Reproducing using latest Nightly, build ID: 20150520030205.

STR:
1. Open Firefox using a RTL locale;
2. Navigate to about:newtab;
3. Click on the cog wheel.

Results:
The new tab option menu item alignment is messed up.

Issue on the:
- He build: http://i.imgur.com/vyShObX.png
- Ar build: http://i.imgur.com/s9h4mrq.png

Also reproduced this using the en-US build by creating a intl.uidirection.en pref and set it's value to RTL.
(Assignee)

Comment 1

6 months ago
Created attachment 8829177 [details]
Screenshot (he)

Issue is a bit better than the previously supplied screenshots, but is still not fully resolved. I'm planning to look into this issue.
Assignee: nobody → tomer.moz.bugs
(Assignee)

Updated

6 months ago
Comment hidden (mozreview-request)
(Assignee)

Updated

6 months ago
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Updated

6 months ago
Attachment #8829213 - Flags: review?(msamuel) → review?(adw)

Comment 4

5 months ago
mozreview-review
Comment on attachment 8829213 [details]
Bug 1167178 - The newtab option menu items are not correctly aligned in RTL builds

https://reviewboard.mozilla.org/r/106360/#review117800

Thanks very much! :-)
Attachment #8829213 - Flags: review?(adw) → review+

Comment 5

5 months ago
And sorry for the big delay.

Updated

5 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

5 months ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 6

5 months ago
Sorry, accidentally marked as RESOLVED FIXED.

Comment 7

5 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/34dcb179266b
The newtab option menu items are not correctly aligned in RTL builds r=adw
Keywords: checkin-needed

Comment 8

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/34dcb179266b
Status: REOPENED → RESOLVED
Last Resolved: 5 months ago5 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Comment 9

5 months ago
Looking good on latest Nightly.

Comment 10

5 months ago
Great, thanks again Tomer.

Updated

5 months ago
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify]

Comment 11

2 months ago
Reproduced the bug in firefox beta 39.0.3 (2015-08-06) with windows 10 (64 bit)

Verified as fixed with latest firefox beta 54.0b7 (Build ID: 20170511130324)

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Whiteboard: [testday-20170512]
You need to log in before you can comment on or make changes to this bug.