1167189 - Replace NS_RUNTIMEABORT("OOM") with something better

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[(Away)]

I see various instances of NS_RUNTIMEABORT("OOM") when people are unable to report a size for NS_ABORT_OOM(size_t). That's unfortunate because those NS_RUNTIMEABORTs don't get counted as OOMs by crash-stats.

At the very least those should be NS_ABORT_OOM(0), or some little helper that does the same. At least then it would show up on crash searches as "OOM | unknown | ..."

As a bonus fix, the NS_RUNTIMEABORT in ImageLoader::AddImage can be removed altogether, since the allocation that it's testing is already infallible (and reports a size).

Comment 1

[(Away)]

https://dxr.mozilla.org/mozilla-central/search?q=regexp%3ANS_RUNTIMEABORT.*%28OOM|of.mem%29

Comment 2

[(Away)]

Attachment: Infallible GetNodeTextcontent

This gets rid of most of the offenders, by funneling them through NS_ABORT_OOM(0).

I'll handle the others case-by-case.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd2239b9df33

Comment 4

[(Away)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=61b9ba61d45b

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bd2239b9df33

Comment 6

[(Away)]

Attachment: Cleanup in layout/

Comment 7

[(Away)]

Comment on attachment 8610806 [details] [diff] [review]
Cleanup in layout/

AFAICT the callees are all infallible (including the allocation in nsNullPrincipal::Create, but that one can also fail for other reasons, so I clarified the message).

Comment 8

[(Away)]

Attachment: Cleanup in dom/

Comment 9

[(Away)]

Attachment: Cleanup in js/xpconnect/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffffedfff053
https://hg.mozilla.org/integration/mozilla-inbound/rev/f53c14ce64b3
https://hg.mozilla.org/integration/mozilla-inbound/rev/6052268bf74a

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ffffedfff053
https://hg.mozilla.org/mozilla-central/rev/f53c14ce64b3
https://hg.mozilla.org/mozilla-central/rev/6052268bf74a

Comment 12

[(Away)]

Comment on attachment 8610809 [details] [diff] [review]
Cleanup in dom/

Requesting uplift to get better diagnostics for bug 1106264 comment 12.

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: poor crash information
[Describe test coverage new/current, TreeHerder]: landed on m-c a while back
[Risks and why]: trivial fix that only affects OOM codepaths
[String/UUID change made/needed]: none

Comment 13

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8610809 [details] [diff] [review]
Cleanup in dom/

Approved for uplift to aurora and beta - to help with crash diagnostics.

Comment 14

[(Away)]

(Setting these flags for the sake of the sheriff scripts)

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0f82f1286aa7

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/561e0bdf9614