Closed Bug 1167208 Opened 9 years ago Closed 9 years ago

Incorrect navigator.userAgent requested via Request Desktop Site

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Version:
39 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38.0.5- verified, firefox39 verified, fennec39+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox38.0.5 - verified
firefox39 --- verified
fennec 39+ ---

People

(Reporter: u421692, Assigned: nalexander)

References

Details

Open http://www.whatsmyua.com/ or http://people.mozilla.org/~atrain/mobile/tests/ua.html

Enable Request desktop site from menu

Actual result:
The mobile user agent is displayed 

Only reproducible on this build, works fine on latest Nightly and Aurora.
Works fine on Firefox 38.0b10 and Firefox 38.0.1

When browsing sites enabling the RDS pref, displays the desktop site.
tracking-fennec: --- → ?
tracking-firefox38: --- → ?
Nick found something I missed when landing previous patches:
http://hg.mozilla.org/mozilla-central/rev/c250ce4656d0

I think this means the DOM versions could still be packaged.

I have no idea how this changed from 38.0b10 and 38.0.1

I am too confused over builds/releases to know what "Firefox 38 Beta 1" means in relation to 38.0b10 and 38.0.1 as well. Is "Firefox 38 Beta 1" newer or older?
NI Nick in case we should uplift his fix
Flags: needinfo?(nalexander)
(In reply to Mark Finkle (:mfinkle) from comment #1)
> Nick found something I missed when landing previous patches:
> http://hg.mozilla.org/mozilla-central/rev/c250ce4656d0
> 
> I think this means the DOM versions could still be packaged.
> 
> I have no idea how this changed from 38.0b10 and 38.0.1
> 
> I am too confused over builds/releases to know what "Firefox 38 Beta 1"
> means in relation to 38.0b10 and 38.0.1 as well. Is "Firefox 38 Beta 1"
> newer or older?


Sorry about that, it was a typo, Firefox 39 Beta 1 is affected
Summary: Incorrect navigator.userAgent requested via Request Desktop Site on Firefox 38 Beta 1 → Incorrect navigator.userAgent requested via Request Desktop Site on Firefox 39 Beta 1
[Tracking Requested - why for this release]:
tracking-firefox38: ? → ---
tracking-firefox39: --- → ?
> 11:21  MihaiP: the SiteSpecificUserAgent.js file is the one from https://dxr.mozilla.org/mozilla-central/source/dom/base/SiteSpecificUserAgent.js
tracking-fennec: ? → 39+
Yeah, we should uplift as far as it can go; I'll request on the other ticket.
Depends on: 1121773, 1157319
Flags: needinfo?(nalexander)
[Tracking Requested - why for this release]:

This is now reproducing on Firefox 38.0.5 Beta 4
tracking-firefox38.0.5: --- → ?
Summary: Incorrect navigator.userAgent requested via Request Desktop Site on Firefox 39 Beta 1 → Incorrect navigator.userAgent requested via Request Desktop Site
This ticket will be addressed by getting Bug 1121773 onto all relevant branches.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Mark, do we want to fix that for the 38.0.5 release? Thanks
Flags: needinfo?(mark.finkle)
(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> Mark, do we want to fix that for the 38.0.5 release? Thanks

Based on comment 7, we should try to fix this on 38.0.5 as well.
Flags: needinfo?(mark.finkle)
Nick, as bug 1121773 landed, I guess we can close this one?
status-firefox38.0.5: affected → fixed
tracking-firefox38.0.5: ? → -
Flags: needinfo?(nalexander)
Able to reproduce on 38.0.5 beta 4
Verifying as fixed on 38.0.5 RC build 1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38.0.5: fixed → verified
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
(In reply to Sylvestre Ledru [:sylvestre] from comment #12)
> Nick, as bug 1121773 landed, I guess we can close this one?

Yessir.  (Also, congrats!)
Flags: needinfo?(nalexander)
Fixed on bug 1121773 , removing tracking-firefox39:?
tracking-firefox39: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.