Closed Bug 1167222 Opened 4 years ago Closed 4 years ago
fx-team tip won't build because of an old rustc on my $PATH despite not using --enable-rust
Specifically, 0:04.22 configure:4074: checking for rustc 0:04.22 configure:4121: checking rustc version 0:04.22 configure: error: Rust compiler 0.11-pre 0:04.22 x86_64-apple-darwin is too old. 0:04.22 To compile rust language sources please install at least 0:04.22 version 1.0 of the 'rustc' toolchain and make sure it is 0:04.22 first in your path. 0:04.22 You can verify this by typing 'rustc --version'. 0:04.22 *** Fix above errors and then restart with "/Applications/Xcode.app/Contents/Developer/usr/bin/make -f client.mk build" but my mozconfig is: gkruitbosch-16516:fx-team gkruitbosch$ cat $MOZCONFIG mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/../builds/opt-@CONFIG_GUESS@ so I don't really understand why it's even checking for rustc. Ted says it shouldn't unless --enable-rust is passed, so something's up. :-) Potentially useful info: [16:18:15] ted oh [16:18:22] ted i think we're missing parens in the conditional [16:18:40] ted if test -n "$MOZ_RUST" -a -z "$_RUSTC_MAJOR_VERSION" -o \ "$_RUSTC_MAJOR_VERSION" -lt 1; then [16:18:42] ted rillian: ^^ [16:18:52] ted that wants parens around the latter two bits with the -o
15:21 Gijs ted: where do you want parens? 15:21 Gijs I can test... but I'm not sure where you mean 15:21 ted well 15:21 Gijs after -z and before the ; ? 15:22 ted it needs a little fiddling 15:22 ted like 15:23 ted if test -n "$MOZ_RUST" && test -z "$_RUSTC_MAJOR_VERSION" -o \ "$_RUSTC_MAJOR_VERSION" -lt 1; then 15:23 ted try that^^ 15:24 Gijs ted: wfm 15:24 ted i guess r+ing your own suggested change is bad form 15:24 ted gps: ^^ 15:24 ted or glandium ^^ 15:25 * ted -> run 15:25 Gijs ted: also goes back to yelling at me if I --enable-rust 15:25 Gijs so that lgtm (snipped my own bash-bashing)
Oops, yes. That's the logic I intended.
I landed this: remote: https://hg.mozilla.org/integration/fx-team/rev/e79a3dffaec9
Assignee: nobody → ted
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.