Closed
Bug 1167243
Opened 9 years ago
Closed 9 years ago
Intermittent browser_newtab_enhanced.js | Suggested for {'Web Education'|'Technology'} enthusiasts
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox39 | --- | unaffected |
firefox40 | --- | fixed |
firefox41 | --- | verified |
firefox-esr31 | --- | unaffected |
firefox-esr38 | --- | unaffected |
People
(Reporter: RyanVM, Assigned: emtwo)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: .?)
Attachments
(3 files)
2.37 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
2.51 KB,
patch
|
Details | Diff | Splinter Review | |
2.51 KB,
patch
|
Details | Diff | Splinter Review |
06:28:42 INFO - 781 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Web Education' 06:28:42 INFO - 782 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | pinned history link is enhanced 06:28:42 INFO - 783 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | pinned history link has enhanced image 06:28:42 INFO - 784 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | undefined assertion name 06:28:42 INFO - 785 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | There is no suggested explanation 06:28:42 INFO - 786 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | there is a suggested link followed by an enhanced history link and the remaining history links 06:28:42 INFO - 787 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' 06:28:42 INFO - 788 INFO Console message: [JavaScript Error: "SUGGEST <div xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> Suggested for <strong> Technology </strong> visitors </div>" {file: "chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js" line: 165}] 06:28:42 INFO - 789 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' enthusiasts 06:28:42 INFO - 790 INFO Console message: [JavaScript Error: "SUGGEST <div xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> Suggested for <strong> Technology </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong> </div>" {file: "chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js" line: 176}] 06:28:42 INFO - 791 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Web Education' enthusiasts - 06:28:42 INFO - Stack trace: 06:28:42 INFO - chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js:runTests:188 06:28:42 INFO - self-hosted:InterpretGeneratorResume:716 06:28:42 INFO - self-hosted:next:674 06:28:42 INFO - chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js:TestRunner.next:150 06:28:42 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:867 06:28:42 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:746 06:28:42 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.scheduleWalkerLoop/<:688 06:28:42 INFO - null:null:0 06:28:42 INFO - 792 INFO Console message: [JavaScript Error: "SUGGEST <div xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> Suggested for <strong> Technology </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong> </div>" {file: "chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js" line: 187}]
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Updated•9 years ago
|
OS: Windows XP → All
Hardware: x86 → All
Summary: Intermittent browser_newtab_enhanced.js | Suggested for 'Web Education' enthusiasts → Intermittent browser_newtab_enhanced.js | Suggested for {'Web Education'|'Technology'} enthusiasts
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(edilee)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 3•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #0) > 06:28:42 INFO - 787 INFO TEST-PASS | > browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' The first check passes but there's no reportError... ? > 06:28:42 INFO - 788 INFO Console message: [JavaScript Error: "SUGGEST <div > xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> > Suggested for <strong> Technology </strong> visitors </div>" {file: > "chrome://mochitests/content/browser/browser/base/content/test/newtab/ > browser_newtab_enhanced.js" line: 165}] > 06:28:42 INFO - 789 INFO TEST-PASS | > browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for > 'Technology' enthusiasts second check passes: ok(suggested.indexOf("Suggested for <strong> Technology </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong>") > -1, "Suggested for 'Technology' enthusiasts"); > 06:28:42 INFO - 790 INFO Console message: [JavaScript Error: "SUGGEST <div > xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> > Suggested for <strong> Technology </strong> enthusiasts who visit sites like > <strong> classroom.google.com </strong> </div>" {file: > "chrome://mochitests/content/browser/browser/base/content/test/newtab/ > browser_newtab_enhanced.js" line: 176}] > 06:28:42 INFO - 791 INFO TEST-UNEXPECTED-FAIL | > browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for > 'Web Education' enthusiasts - third check fails: ok(suggested.indexOf("Suggested for <strong> Web Education </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong>") > -1, "Suggested for 'Web Education' enthusiasts");
Assignee: nobody → msamuel
Blocks: 1139496
Flags: needinfo?(edilee) → needinfo?(msamuel)
Whiteboard: .?
Comment 4•9 years ago
|
||
Also comment 2 shows it failed for two items: for 'Technology' - for 'Technology' enthusiasts -
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 7•9 years ago
|
||
I wasn't able to reproduce these errors at all even when I reran the jobs many times. However, my guess is that sometimes a new tab is opened before the links in the updated pref have been processed so a new tab shows an outdated suggested tile. So we can wait for the links to be processed before we open a new tab.
Flags: needinfo?(msamuel)
Attachment #8609618 -
Flags: review?(adw)
Comment 8•9 years ago
|
||
Comment on attachment 8609618 [details] [diff] [review] v1: Wait for new links to be processed before opening a new tab Review of attachment 8609618 [details] [diff] [review]: ----------------------------------------------------------------- Sounds plausible. You pushed this to try to make sure it doesn't make the problem even worse, right?
Attachment #8609618 -
Flags: review?(adw) → review+
Comment 9•9 years ago
|
||
I pushed this to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a772e0ca0dd I'll retrigger a bunch of bc1 for all platforms. So far the starred items have been from os x 10.10 opt and win32 debug.
Comment 10•9 years ago
|
||
(In reply to Ed Lee :Mardak from comment #9) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a772e0ca0dd I retriggered 100x of bc1 for each But then I realized 10.10 isn't run by default, so I pushed this extra try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a245cd41ed1e
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 12•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc63eaf2e746 This is the try build I ran with several bc1 retriggers I just added a few more for other platforms... It didn't have 10.10 though... also had some debug logging
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 14•9 years ago
|
||
After 1300 emtwo's try and 1300 my try and 300 more bc1 for 10.10.. I think we should be good. Thanks for digging into this emtwo!
Comment 16•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e756c4880a95
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Reporter | ||
Updated•9 years ago
|
status-firefox39:
--- → unaffected
status-firefox40:
--- → unaffected
status-firefox-esr31:
--- → unaffected
status-firefox-esr38:
--- → unaffected
Comment 17•9 years ago
|
||
Comment 18•9 years ago
|
||
Comment 19•9 years ago
|
||
I believe comment 14 is verification enough!
Comment 20•9 years ago
|
||
Comment on attachment 8610030 [details] [diff] [review] for aurora (Mardak will land) Approval Request Comment: See bug 1140185 comment 11
Attachment #8610030 -
Flags: approval-mozilla-aurora?
Comment 21•9 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/e5bb6c8253ed
Flags: firefox-backlog+
Comment 22•9 years ago
|
||
Comment on attachment 8610030 [details] [diff] [review] for aurora (Mardak will land) approval-mozilla-aurora+ granted in bug 1140185 comment 14
Attachment #8610030 -
Flags: approval-mozilla-aurora?
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 24•9 years ago
|
||
[Mass Closure] Closing Intermittent as a one off
Updated•9 years ago
|
Status: VERIFIED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: FIXED → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•