1167243 - Intermittent browser_newtab_enhanced.js | Suggested for {'Web Education'|'Technology'} enthusiasts

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

06:28:42 INFO - 781 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Web Education'
06:28:42 INFO - 782 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | pinned history link is enhanced
06:28:42 INFO - 783 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | pinned history link has enhanced image
06:28:42 INFO - 784 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | undefined assertion name
06:28:42 INFO - 785 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | There is no suggested explanation
06:28:42 INFO - 786 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | there is a suggested link followed by an enhanced history link and the remaining history links
06:28:42 INFO - 787 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology'
06:28:42 INFO - 788 INFO Console message: [JavaScript Error: "SUGGEST <div xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> Suggested for <strong> Technology </strong> visitors </div>" {file: "chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js" line: 165}]
06:28:42 INFO - 789 INFO TEST-PASS | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' enthusiasts
06:28:42 INFO - 790 INFO Console message: [JavaScript Error: "SUGGEST <div xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> Suggested for <strong> Technology </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong> </div>" {file: "chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js" line: 176}]
06:28:42 INFO - 791 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Web Education' enthusiasts -
06:28:42 INFO - Stack trace:
06:28:42 INFO - chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js:runTests:188
06:28:42 INFO - self-hosted:InterpretGeneratorResume:716
06:28:42 INFO - self-hosted:next:674
06:28:42 INFO - chrome://mochitests/content/browser/browser/base/content/test/newtab/head.js:TestRunner.next:150
06:28:42 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:867
06:28:42 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:746
06:28:42 INFO - resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.scheduleWalkerLoop/<:688
06:28:42 INFO - null:null:0
06:28:42 INFO - 792 INFO Console message: [JavaScript Error: "SUGGEST <div xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds"> Suggested for <strong> Technology </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong> </div>" {file: "chrome://mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_enhanced.js" line: 187}]

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1538114
repository: mozilla-central
start_time: 2015-05-21T07:07:58
who: rvandermeulen[at]mozilla[dot]com
machine: t-xp32-ix-151
buildname: Windows XP 32-bit mozilla-central debug test mochitest-browser-chrome-1
revision: 91197924c93e

791 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Web Education' enthusiasts -
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=10043728
repository: mozilla-inbound
start_time: 2015-05-21T08:25:12
who: rvandermeulen[at]mozilla[dot]com
machine: t-yosemite-r5-0042
buildname: Rev5 MacOSX Yosemite 10.10 mozilla-inbound opt test mochitest-browser-chrome-1
revision: 681762b5ea5d

"comments": "Bug 1162134 - IonMonkey MIPS: Fix build failure on MIPS (js/src/jit/CodeGenerator.cpp:6740:28: error: obj was not declared in this scope). r=bhackett",
779 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' -
781 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' enthusiasts -

Comment 3

[Ed Lee :Mardak]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #0)
> 06:28:42 INFO - 787 INFO TEST-PASS | 
> browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology'
The first check passes but there's no reportError... ?

> 06:28:42 INFO - 788 INFO Console message: [JavaScript Error: "SUGGEST <div
> xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds">
> Suggested for <strong> Technology </strong> visitors </div>" {file:
> "chrome://mochitests/content/browser/browser/base/content/test/newtab/
> browser_newtab_enhanced.js" line: 165}]
> 06:28:42 INFO - 789 INFO TEST-PASS |
> browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for
> 'Technology' enthusiasts

second check passes:
  ok(suggested.indexOf("Suggested for <strong> Technology </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong>") > -1, "Suggested for 'Technology' enthusiasts");


> 06:28:42 INFO - 790 INFO Console message: [JavaScript Error: "SUGGEST <div
> xmlns="http://www.w3.org/1999/xhtml" class="newtab-suggested-bounds">
> Suggested for <strong> Technology </strong> enthusiasts who visit sites like
> <strong> classroom.google.com </strong> </div>" {file:
> "chrome://mochitests/content/browser/browser/base/content/test/newtab/
> browser_newtab_enhanced.js" line: 176}]
> 06:28:42 INFO - 791 INFO TEST-UNEXPECTED-FAIL |
> browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for
> 'Web Education' enthusiasts -

third check fails:

  ok(suggested.indexOf("Suggested for <strong> Web Education </strong> enthusiasts who visit sites like <strong> classroom.google.com </strong>") > -1, "Suggested for 'Web Education' enthusiasts");

Comment 4

[Ed Lee :Mardak]

Also comment 2 shows it failed for two items:

for 'Technology' -
for 'Technology' enthusiasts -

Comment 5

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=fx-team&job_id=3164856
repository: fx-team
start_time: 2015-05-21T23:59:24
who: ttaubert[at]mozilla[dot]com
machine: t-yosemite-r5-0010
buildname: Rev5 MacOSX Yosemite 10.10 fx-team opt test mochitest-browser-chrome-1
revision: 52be40f91144

783 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Web Education' enthusiasts -

Comment 6

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=10082831
repository: mozilla-inbound
start_time: 2015-05-22T11:25:28
who: rvandermeulen[at]mozilla[dot]com
machine: t-yosemite-r5-0049
buildname: Rev5 MacOSX Yosemite 10.10 mozilla-inbound opt test mochitest-browser-chrome-1
revision: bc1f37d99d6d

779 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' -
781 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' enthusiasts -

Comment 7

[Marina Samuel [:emtwo]]

Attachment: v1: Wait for new links to be processed before opening a new tab

I wasn't able to reproduce these errors at all even when I reran the jobs many times.

However, my guess is that sometimes a new tab is opened before the links in the updated pref have been processed so a new tab shows an outdated suggested tile.

So we can wait for the links to be processed before we open a new tab.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 8609618 [details] [diff] [review]
v1: Wait for new links to be processed before opening a new tab

Review of attachment 8609618 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds plausible.  You pushed this to try to make sure it doesn't make the problem even worse, right?

Comment 9

[Ed Lee :Mardak]

I pushed this to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a772e0ca0dd

I'll retrigger a bunch of bc1 for all platforms. So far the starred items have been from os x 10.10 opt and win32 debug.

Comment 10

[Ed Lee :Mardak]

(In reply to Ed Lee :Mardak from comment #9)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a772e0ca0dd
I retriggered 100x of bc1 for each


But then I realized 10.10 isn't run by default, so I pushed this extra try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a245cd41ed1e

Comment 11

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=10096288
repository: mozilla-inbound
start_time: 2015-05-22T15:13:51
who: philringnalda[at]gmail[dot]com
machine: t-yosemite-r5-0072
buildname: Rev5 MacOSX Yosemite 10.10 mozilla-inbound opt test mochitest-browser-chrome-1
revision: 6fe131387fb2

780 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' -
782 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' enthusiasts -

Comment 12

[Marina Samuel [:emtwo]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc63eaf2e746 This is the try build I ran with several bc1 retriggers I just added a few more for other platforms... It didn't have 10.10 though... also had some debug logging

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=10103133
repository: mozilla-inbound
start_time: 2015-05-22T21:48:13
who: philringnalda[at]gmail[dot]com
machine: t-yosemite-r5-0038
buildname: Rev5 MacOSX Yosemite 10.10 mozilla-inbound opt test mochitest-browser-chrome-1
revision: 10d6fcd9a4e0

779 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Technology' -

Comment 14

[Ed Lee :Mardak]

After 1300 emtwo's try and 1300 my try and 300 more bc1 for 10.10.. I think we should be good.

Thanks for digging into this emtwo!

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e756c4880a95

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e756c4880a95

Comment 17

[Ed Lee :Mardak]

Attachment: for aurora (Mardak will land)

Comment 18

[Ed Lee :Mardak]

Attachment: for beta (Mardak will land)

Comment 19

[Ed Lee :Mardak]

I believe comment 14 is verification enough!

Comment 20

[Ed Lee :Mardak]

Comment on attachment 8610030 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment: See bug 1140185 comment 11

Comment 21

[Ed Lee :Mardak]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e5bb6c8253ed

Comment 22

[Ed Lee :Mardak]

Comment on attachment 8610030 [details] [diff] [review]
for aurora (Mardak will land)

approval-mozilla-aurora+ granted in bug 1140185 comment 14

Comment 23

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-aurora&job_id=856545
repository: mozilla-aurora
start_time: 2015-05-27T18:29:15
who: rvandermeulen[at]mozilla[dot]com
machine: tst-linux32-spot-534
buildname: Ubuntu VM 12.04 mozilla-aurora pgo test mochitest-browser-chrome-1
revision: 2ce1d8162c4a

781 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/newtab/browser_newtab_enhanced.js | Suggested for 'Web Education' enthusiasts -

Comment 24

[David Burns :automatedtester]

[Mass Closure] Closing Intermittent as a one off