1167249 - ssltunnel.cpp:1321:9: warning: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Wmismatched-new-delete]

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Daniel Holbert [:dholbert]]

New build warnings, when compiling mozilla-inbound with clang 3.7:
{
 5:25.78 Warning: -Wmismatched-new-delete in /scratch/work/builds/mozilla-inbound/mozilla/testing/mochitest/ssltunnel/ssltunnel.cpp: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'?
 5:25.78 /scratch/work/builds/mozilla-inbound/mozilla/testing/mochitest/ssltunnel/ssltunnel.cpp:1321:9: warning: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Wmismatched-new-delete]
 5:25.78         delete hostname_copy;
 5:25.78         ^
 5:25.78               []
 5:25.78 /scratch/work/builds/mozilla-inbound/mozilla/testing/mochitest/ssltunnel/ssltunnel.cpp:1306:29: note: allocated with 'new[]' here
 5:25.78       char *hostname_copy = new char[strlen(hostname)+strlen(hostportstring)+2];
 5:25.78                             ^
 5:25.79 Warning: -Wmismatched-new-delete in /scratch/work/builds/mozilla-inbound/mozilla/testing/mochitest/ssltunnel/ssltunnel.cpp: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'?
 5:25.79 /scratch/work/builds/mozilla-inbound/mozilla/testing/mochitest/ssltunnel/ssltunnel.cpp:1322:9: warning: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Wmismatched-new-delete]
 5:25.79         delete redir_copy;
 5:25.79         ^
 5:25.79               []
 5:25.79 /scratch/work/builds/mozilla-inbound/mozilla/testing/mochitest/ssltunnel/ssltunnel.cpp:1316:26: note: allocated with 'new[]' here
 5:25.79       char *redir_copy = new char[strlen(redirhoststring)+1];
 5:25.79                          ^
}


Looks like these delete statements were introduced in
 https://hg.mozilla.org/integration/mozilla-inbound/rev/c4bab6f234f6

Comment 1

[Daniel Holbert [:dholbert]]

Ryan, would you mind taking this? I think we just need to convert these delete statements (for hostname_copy and redir_copy) to use "delete[]"?

Comment 2

[Daniel Holbert [:dholbert]]

Actually, I'll just take this, since it's trivial and I'm not sure if other compilers warn about this clearly.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 4

[Daniel Holbert [:dholbert]]

Attachment: fix (more lines of context)

Updated the fix to have more lines of context, so you can see the "new" statements that do the allocation for these variables. (to verify that it's really new[])

Comment 5

[Ryan Nath [:rnath]]

Daniel, looks like my compiler didn't pick this warning up. Sorry about that!

Comment 6

[Daniel Holbert [:dholbert]]

No worries -- delete/delete[] is an easy mistake to make (and I think it might only be a warning in newer compiler versions, maybe only clang 3.7).

(I also filed Bug 1167250 will make us treat build warnings in this directory as errors from now on, to make issues like this more likely to be caught.)

Comment 7

[Daniel Holbert [:dholbert]]

Green try run (with Bug 1167250 layered on top, as well):
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=601de87bfb88

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4387922c102

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d4387922c102