Closed
Bug 1167250
Opened 9 years ago
Closed 9 years ago
Annotate testing/mochitest/ssltunnel as FAIL_ON_WARNINGS
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
613 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Build warnings aren't currently fatal in testing/mochitest/ssltunnel , which means I only caught bug 1167249 by chance, from noticing it go by in the buildspew. We should make warnings fatal in this directory with FAIL_ON_WARNINGS.
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49436fe1292 Nearly complete, & green everywhere (so far). (I was hoping one the builds might be red due to bug 1167249's warning being promoted to an error, but it looks like none of our builders use compilers with that warning. :( I did verify that this patch busts my local build, without bug 1167249's patch, though -- so that's good.)
|
||
Updated•9 years ago
|
Attachment #8608865 -
Flags: review?(ted) → review+
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/269a9ed20950
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•