1167254 - convert the test added in bug 234856 to an xpcshell test

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Bug 234856 added a mochitest-chrome test to ensure that some properties of a certificate are decoded properly. However, I can determine no compelling reason for it to be a mochitest-chrome test rather than an xpcshell test. Since mochitests require more test resources, we should just convert it to an xpcshell test.

Comment 1

[:Cykesiopka]

Attachment: MozReview Request: bz://1167254/Cykesiopka

/r/9423 - Bug 1167254 - Convert test_bug234856.html mochitest to an xpcshell test.

Pull down this commit:

hg pull -r 9194594f4e2f36d7955a16775bb615c9780ac34a https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[:Cykesiopka]

https://reviewboard.mozilla.org/r/9421/#review8173

I didn't do a |hg rename| because I touch every single line, and because no changes have been made to test_bug234856.html since it landed.
However, I can redo the patch using |hg rename| if preferred.

::: security/manager/ssl/tests/unit/test_nsIX509Cert_utf8.js:45
(Diff revision 1)
> +  equal(cert.nickname, "(no nickname)",

I left out the first five checks before this one, because I don't see how they are relevant to what this test is supposed to be testing.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

https://reviewboard.mozilla.org/r/9423/#review8219

Great - thanks. The new file should have a license, though.

::: security/manager/ssl/tests/unit/test_nsIX509Cert_utf8.js:1
(Diff revision 1)
> +// -*- indent-tabs-mode: nil; js-indent-level: 2 -*-

nit: this file needs a license, I think. Either MPL 2.0 or public domain should work.

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

https://reviewboard.mozilla.org/r/9423/#review8223

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8611085 [details]
MozReview Request: bz://1167254/Cykesiopka

https://reviewboard.mozilla.org/r/9421/#review8225

Comment 6

[:Cykesiopka]

https://reviewboard.mozilla.org/r/9423/#review8309

> nit: this file needs a license, I think. Either MPL 2.0 or public domain should work.

The original file was added before 2014-09-23 (see "PD Test Code" in https://www.mozilla.org/MPL/license-policy.html ), so just to be safe, MPL it is.

Comment 7

[:Cykesiopka]

Attachment: bug1167254_convert-test_bug234856.html-to-xpcshell_v2.patch

+ Add license header

Comment 8

[:Cykesiopka]

Thanks for the review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=484d723e6da2

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43ac1e38b7ac

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43ac1e38b7ac

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43ac1e38b7ac