1167283 - Add mach command to create local testing environment

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect, P3)

Description

[Dan Minor [:dminor]]

It looks like all the mozreview developers have different scripts to create an environment for local testing outside of running the unit tests. It would be beneficial to take the good parts of these and create a mach command for local testing.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: add Bugzilla group support to `mozreview create-user`

testing: add Bugzilla group support to `mozreview create-user`

By adding this, `mozreview create-user` should now be able to create
both a Bugzilla and LDAP/system user in one command. Previously, we
needed multiple commands to accomplish this.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: use `mozreview create-user` to create users

testing: use `mozreview create-user` to create users

Before, we had multiple commands for creating a Bugzilla user and an
LDAP/system user. Now, we use a single command. This will be the
preferred user creation mechanism going forward, at least for users that
require accounts in both systems.

Comment 3

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/11605/#review10025

This series is incomplete. But since it conflicts with stuff mcote is working on, I figure we should get it landed.

Docs updates and other improvements will be added later.

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: rewrite mozreview-ssh as a Python script

testing: rewrite mozreview-ssh as a Python script

We want to add functionality to this. That will be much easier once it
is written in Python instead of shell.

Support for SSH_USERNAME has been removed since it isn't used anywhere.

Comment 5

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: store credentials for created users

testing: store credentials for created users

We want the ability to easily look up credentials for created users.
Store the credentials in plain text.

Comment 6

[Gregory Szorc [:gps]]

Attachment: MozReview Request: testing: easily create configured clones of review repositories

testing: easily create configured clones of review repositories

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8623901 [details]
MozReview Request: testing: add Bugzilla group support to `mozreview create-user`

https://reviewboard.mozilla.org/r/11607/#review10109

Ship It!

Comment 8

[Steven MacLeod [:smacleod]]

Comment on attachment 8623902 [details]
MozReview Request: testing: use `mozreview create-user` to create users

https://reviewboard.mozilla.org/r/11609/#review10111

Ship It!

Comment 9

[Steven MacLeod [:smacleod]]

Comment on attachment 8623953 [details]
MozReview Request: testing: rewrite mozreview-ssh as a Python script

https://reviewboard.mozilla.org/r/11617/#review10113

Ship It!

Comment 10

[Steven MacLeod [:smacleod]]

Comment on attachment 8623954 [details]
MozReview Request: testing: store credentials for created users

https://reviewboard.mozilla.org/r/11619/#review10115

Ship It!

Comment 11

[Steven MacLeod [:smacleod]]

Comment on attachment 8623955 [details]
MozReview Request: testing: easily create configured clones of review repositories

https://reviewboard.mozilla.org/r/11621/#review10117

This stuff is __great__ - thanks for taking care of it.

::: docs/hacking-mozreview.rst:181
(Diff revision 1)
> +Creating Configured Repository Clones

Super bonus points request - allow me to point this at an existing clone of *some* hg repository, and have the command (possibly prompting before doing it) overwrite the hgrc.

This makes it easy for me to reuse a testing repository with certain commits set up, rather than having to manually pull the changes over to the repo etc.

::: testing/vcttesting/mozreview.py:362
(Diff revision 1)
> -    def create_repository(self, name):
> +    def repo_urls(self, name):

I'd love it if we could expose this as a command as well (or a command which just outputs *every* url - rbweb, bmo, hg [including all repos], etc.)

Comment 12

[Gregory Szorc [:gps]]

Landed the first series. There's still some more work to make this turnkey.

Comment 13

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.