Expand the cross-compartment checks we do during marking

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8608888 [details] [diff] [review]
25_generalize_xcompartment_check-v0.diff

I'm a bit annoyed to need maybeCompartment, since we should be able to statically determine if there is a compartment method on T. Unfortunately the tricks I used to capture this were universally longer or more complicated than this approach, or crashed gcc, clang, or gdb. On the other hand, this approach does let us effectively remove the MaybeCompartment method in jsgc.cpp. That patch is a bit lower in my queue, but does make this approach end up paying for itself pretty handily.
Attachment #8608888 - Flags: review?(jcoppeard)

Updated

3 years ago
Attachment #8608888 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/135e5915f52d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.