Closed Bug 1167291 Opened 8 years ago Closed 8 years ago

Expand the cross-compartment checks we do during marking

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I'm a bit annoyed to need maybeCompartment, since we should be able to statically determine if there is a compartment method on T. Unfortunately the tricks I used to capture this were universally longer or more complicated than this approach, or crashed gcc, clang, or gdb. On the other hand, this approach does let us effectively remove the MaybeCompartment method in jsgc.cpp. That patch is a bit lower in my queue, but does make this approach end up paying for itself pretty handily.
Attachment #8608888 - Flags: review?(jcoppeard)
Attachment #8608888 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/mozilla-central/rev/135e5915f52d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.