Viewing messages with attactments displays the file name of the link on the link or too close to the link

VERIFIED FIXED in M9

Status

MailNews Core
Composition
P3
major
VERIFIED FIXED
18 years ago
9 years ago

People

(Reporter: esther, Assigned: rhp (gone))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
Using 19990811 on win98 when viewing a message with a .gif image file (no vcard
or signature), there is a box with the file name w/link for the image displayed
right up against the bottom of the image.

0. Send yourself a message with a .gif file as a link, no signature or vCard.
1. Launch Messenger
2. Select the folder that has the message you just sent and select the message.
I see a box up against the bottom of the image, with the image file name and
a link for that file.

The box looks like it doesn't belong and is too close to the image.
Note: if you have a vCard, the vCard is displayed between the image and the box
with the file name.
(Assignee)

Updated

18 years ago
Severity: normal → major
Status: NEW → ASSIGNED
Target Milestone: M9
(Assignee)

Comment 1

18 years ago
After investigating, I realized that the attachment display was very broken for
the old style of display. I have a safe fix for this that I would like to
checkin.

Chris: can I checkin the following:

Index: mimehdrs.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/mime/src/mimehdrs.cpp,v
retrieving revision 1.20
diff -c -r1.20 mimehdrs.cpp
*** mimehdrs.cpp	1999/08/11 05:04:00	1.20
--- mimehdrs.cpp	1999/08/12 00:29:38
***************
*** 2505,2511 ****
      pref->GetBoolPref("mail.mime_xul_output", &mimeXULOutput);

    if (!mimeXULOutput)
!     status = MimeHeaders_write_all_headers (hdrs, opt, TRUE);

    if (status < 0)
      return status;
--- 2505,2516 ----
      pref->GetBoolPref("mail.mime_xul_output", &mimeXULOutput);

    if (!mimeXULOutput)
!   {
!     mimeEmitterStartAttachment(opt, lname, content_type, lname_url);
!     status = MimeHeaders_write_all_headers (hdrs, opt, PR_TRUE);
!     mimeEmitterAddAttachmentField(opt, HEADER_X_MOZILLA_PART_URL, lname_url);
!     mimeEmitterEndAttachment(opt);
!   }

    if (status < 0)
      return status;
Index: mimemoz2.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/mime/src/mimemoz2.cpp,v
retrieving revision 1.34
diff -c -r1.34 mimemoz2.cpp
*** mimemoz2.cpp	1999/08/11 00:29:43	1.34
--- mimemoz2.cpp	1999/08/12 00:29:38
***************
*** 252,257 ****
--- 252,266 ----
    PRInt32     i = 0;
    struct      nsMsgAttachmentData  *tmp = data;

+   // RICHIE SHERRY - this will go away once we cutover...
+   nsIPref *pref = GetPrefServiceManager(opt);   // Pref service manager
+   PRBool      mimeXULOutput = PR_FALSE;
+
+   if (pref)
+     pref->GetBoolPref("mail.mime_xul_output", &mimeXULOutput);
+   if (!mimeXULOutput)
+     return;
+
    if ( (!tmp) || (!tmp->real_name) )
      return;
(Assignee)

Updated

18 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

18 years ago
Ok, I got this working again. It should look like M8 again.

- rhp
(Reporter)

Updated

18 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 3

18 years ago
works like M8, verified.
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.