1167312 - Remove Amazon and IMDb from shumway.swf.whitelist pref

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Chris Peterson [:cpeterson]]

Amazon and IMDb videos are currently broken (bug 1150189 and bug 1164013). Tobias says IMDb is now using HLS video, repacking into MP4 in Flash. Amazon is probably doing something similar.

Since the Shumway team's current focus is Flash ads, not videos, we should just remove Amazon and IMDB from our shumway.swf.whitelist pref since this seems to be a content change, not a Shumway regression.

See bug 1137433 for the code where IMDb was added to the shumway.swf.whitelist pref.

Comment 1

[Yury Delendik (:yury)]

Please notice that pref entry shall exist and be set to the non-empty value. I suggest "http://www.areweflashyet.com/*".

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: shumway-whitelist-pref.patch

Replace the Amazon/IMDb whitelist with the whitelist that Yury recommended in comment 1, but include a "*.swf" suffix because that is pattern format that was used for the Amazon/IMDb patterns. It's also Shumway's default whitelist for platforms that don't support platform video decoders:

https://github.com/mozilla/shumway/blob/a7de3ad334098582ddb630a85e088a10b29b56db/extension/firefox/content/ShumwayBootstrapUtils.jsm#L121

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 8611032 [details] [diff] [review]
shumway-whitelist-pref.patch

Review of attachment 8611032 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent, thank you!

I filed bug 1168761 for removing some special-casing in our code.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/578160b452ec

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/578160b452ec