Closed Bug 1167344 Opened 5 years ago Closed 4 years ago

[Add-on Manager][Settings] Need to pass a 'manifestURL' option to section:addons MozActivity

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justindarc, Assigned: yzen)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

In the MozActivity for displaying the Add-on Manager (the screen listing all installed add-ons), we need to be able to pass a `manifestURL` option that filters the listing to only show add-ons that affect the app with the provided `manifestURL`.
Assignee: nobody → yzenevich
Priority: -- → P1
Whiteboard: [spark]
Attachment #8610803 - Flags: review?(arthur.chen)
Comment on attachment 8610803 [details] [review]
[gaia] yzen:bug-1167344 > mozilla-b2g:master

Thanks for the patch, yura.

My suggestion on the patch is implementing the filter outside of AddonManager. That would give us more flexibility on supporting possible use cases in the future.
 
Regarding the filter itself, for this time being there is no way to set a filter directly on an observable array (I should add this part :p), but you can observe the changes from addons#AddonManager and update another observable array that is bound to the list view. addons_list.js seems a good place for setting these things up.
Attachment #8610803 - Flags: review?(arthur.chen)
Comment on attachment 8610803 [details] [review]
[gaia] yzen:bug-1167344 > mozilla-b2g:master

Hopefully looks better now, thanks!
Attachment #8610803 - Flags: review?(arthur.chen)
Comment on attachment 8610803 [details] [review]
[gaia] yzen:bug-1167344 > mozilla-b2g:master

r=me with the last comment addressed, thanks!
Attachment #8610803 - Flags: review?(arthur.chen) → review+
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/pull/30246

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
Keywords: checkin-needed
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/f1224fcad2899ef458a1ce5cecee703412ba25e0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.