1167349 - Turn swagger back on in production (and paginate any api's which aren't already)

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, defect)

Description

[William Lachance (:wlach)]

In bug 1065786 we disabled swagger on production. It was really useful though! We should turn it back, after paginating any api endpoints which aren't currently  (to prevent accidental DDOS, the original concern here).

Mauro, do you know which api's we need to look into here offhand?

Comment 1

[Mauro Doglio [:mdoglio]]

The only endpoints I would check are the ones in PerformanceDataViewSet and BugscacheViewSet. The former because I don't know the maximum size of the dataset returned, the latter because now we have several thousands intermittent bugs and I guess with the right search string you can fetch most of them.

Comment 2

[William Lachance (:wlach)]

Going to try to get this turned back on in advance of Whistler.

Comment 3

[William Lachance (:wlach)]

(In reply to Mauro Doglio [:mdoglio] from comment #1)
> The only endpoints I would check are the ones in PerformanceDataViewSet and
> BugscacheViewSet. The former because I don't know the maximum size of the
> dataset returned, the latter because now we have several thousands
> intermittent bugs and I guess with the right search string you can fetch
> most of them.

It looks like BugscacheViewSet's output is essentially capped at 50 because of the underlying method in refdata.py:

https://github.com/mozilla/treeherder/blob/master/treeherder/model/derived/refdata.py#L1374

There are no methods in PerformanceDataViewSet that return an unbounded set of results:

https://github.com/mozilla/treeherder/blob/master/treeherder/webapp/api/performance_data.py

I'd say we're probably good to just turn this back on.

Comment 4

[William Lachance (:wlach)]

Attachment: PR

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5fea0d4b134308ae759ea3995047fbc608a26321
Bug 1167349 - Turn swagger back on in production and update to latest