1167351 - Display JS function name in markers

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Front end for bug 1050500

Comment 1

[Tom Tromey :tromey]

I think there's nothing to do here because the function-to-be-called is
represented as a sort of phony stack frame.  This is slightly weird but
it came from trying to also deal with the async stack; which has subsequently
been postponed.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

ah, so we won't have the entry JS function name here with bug 1050500? Or only for async stacks?

Comment 3

[Tom Tromey :tromey]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #2)
> ah, so we won't have the entry JS function name here with bug 1050500? Or
> only for async stacks?

We'll have the name, but the code in marker-details.js will display it without
any further changes, as it will look like a stack with a single frame.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Marker views are a lot nicer now, more declarative, so taking this single frame stack and turning it into be displayed is easy

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

I think this is good to go in that case, TT can you confirm?

Comment 6

[Tom Tromey :tromey]

Yes, I think this bug was already fixed by bug 1050500.

Comment 7

[Tom Tromey :tromey]

Really clearing needinfo.

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Resolving this in that case