Closed
Bug 1167377
Opened 9 years ago
Closed 9 years ago
[Customizer Launcher] Auto-enable the Customizer add-on if dev-mode is enabled
Categories
(Firefox OS Graveyard :: Gaia::Customizer, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: pdahiya)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
When the Customizer Launcher is opened, after checking for dev-mode (see Bug 1161157), we should check if the Customizer add-on is enabled and if not, enable it automatically for the user.
Reporter | ||
Comment 1•9 years ago
|
||
Assigning to Punam to work on after Bug 1161677 lands.
Assignee: nobody → pdahiya
Blocks: spark-customizer-launcher
Depends on: 1161677
Priority: -- → P1
Whiteboard: [spark]
Assignee | ||
Comment 2•9 years ago
|
||
Hi Justin Attached PR enables customizer add-on on the device before loading list of apps inside CL. It also include nit fixes a) removing dev logs b) excluding 'Customizer Launcher' from list of apps showing in CL c) Launcher web server default response. Please review. Thanks!
Assignee | ||
Updated•9 years ago
|
Attachment #8612435 -
Flags: review?(jdarcangelo)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8612435 [details] [review] PR with fix of Bug 1167377 I really like the pattern you used with the promises! Anyhow, I put a couple nits in the PR. The only one I'm concerned about addressing before landing is to change the apps filter use manifestURL instead of the name.
Attachment #8612435 -
Flags: review?(jdarcangelo) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks Justin for review. Patch updated with feedback and landed. https://github.com/fxos/customizer-launcher/commit/f659dcd19f104d26e2aefbb2b2bda71175b1f750
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•