Closed Bug 1167380 Opened 5 years ago Closed 5 years ago

Use nsCOMPtr in WriteSegmentsState and ReadSegmentsState and mark as MOZ_STACK_CLASS

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: Nika, Assigned: Nika)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Blocks: 1114683
Attachment #8609002 - Flags: review?(nfroyd)
Comment on attachment 8609002 [details] [diff] [review]
Use nsCOMPtr in WriteSegmentsState and ReadSegmentsState and mark as MOZ_STACK_CLASS

Review of attachment 8609002 [details] [diff] [review]:
-----------------------------------------------------------------

+1 on MOZ_STACK_CLASS, -0 on using nsCOMPtr here.  I think it'd be better to mark it as MOZ_NON_OWNING_REF and move on.
Attachment #8609002 - Flags: review?(nfroyd) → feedback+
Comment on attachment 8612324 [details] [diff] [review]
Mark (Read/Write)SegmentsState::m(Source/Sink) as MOZ_NON_OWNING_REF and mark as MOZ_STACK_CLASS

Review of attachment 8612324 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8612324 - Flags: review?(nfroyd) → review+
Assignee: nobody → michael
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/11e4bab408f2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.