Closed
Bug 1167380
Opened 9 years ago
Closed 9 years ago
Use nsCOMPtr in WriteSegmentsState and ReadSegmentsState and mark as MOZ_STACK_CLASS
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
Details
Attachments
(1 file, 1 obsolete file)
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8609002 -
Flags: review?(nfroyd)
Comment 2•9 years ago
|
||
Comment on attachment 8609002 [details] [diff] [review] Use nsCOMPtr in WriteSegmentsState and ReadSegmentsState and mark as MOZ_STACK_CLASS Review of attachment 8609002 [details] [diff] [review]: ----------------------------------------------------------------- +1 on MOZ_STACK_CLASS, -0 on using nsCOMPtr here. I think it'd be better to mark it as MOZ_NON_OWNING_REF and move on.
Attachment #8609002 -
Flags: review?(nfroyd) → feedback+
Assignee | ||
Comment 3•9 years ago
|
||
new try: https://bugzilla.mozilla.org/show_bug.cgi?id=1167380
Attachment #8609002 -
Attachment is obsolete: true
Attachment #8612324 -
Flags: review?(nfroyd)
Comment 4•9 years ago
|
||
Comment on attachment 8612324 [details] [diff] [review] Mark (Read/Write)SegmentsState::m(Source/Sink) as MOZ_NON_OWNING_REF and mark as MOZ_STACK_CLASS Review of attachment 8612324 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #8612324 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → michael
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/11e4bab408f2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•