1167389 - Make FileList::mParent a smart pointer, and declare it to the cycle collector

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb0c571df4d7

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Mark FileList::mParent as MOZ_UNSAFE_REF

Comment 2

[(no longer active)]

Comment on attachment 8609008 [details] [diff] [review]
Mark FileList::mParent as MOZ_UNSAFE_REF

Review of attachment 8609008 [details] [diff] [review]:
-----------------------------------------------------------------

We should be able to make this a strong ref and declare it to the cycle collector.  See Blob::mParent for a very similar case.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make FileList::mParent a smart pointer, and declare it to the cycle collector

I declared it to the cycle collector, let's see if it acts leaky on try (I think it should be OK based on looking at it's consumers).
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f79fcb14051

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make FileList::mParent a smart pointer, and declare it to the cycle collector

Fixed some destructor problems...
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=403e40ab6a51

Comment 5

[Carsten Book [:Tomcat]]

Hi, this patch failed to apply:

adding 1167389 to series file
renamed 1167389 -> Bug-1167389---Make-FileListmParent-a-smart-pointer.patch
applying Bug-1167389---Make-FileListmParent-a-smart-pointer.patch
patching file dom/base/File.cpp
Hunk #1 FAILED at 1217
1 out of 1 hunks FAILED -- saving rejects to file dom/base/File.cpp.rej
patching file dom/base/File.h
Hunk #1 succeeded at 986 with fuzz 2 (offset 159 lines).
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1167389---Make-FileListmParent-a-smart-pointer.patch

could you take a look, thanks!

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make FileList::mParent a smart pointer, and declare it to the cycle collector

Rebased.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6708b7f99529

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6708b7f99529