Mark nsNodeWeakReference::mNode as MOZ_NON_OWNING_REF

RESOLVED FIXED in Firefox 42

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mystor, Assigned: mystor)

Tracking

(Blocks: 1 bug)

unspecified
mozilla42
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=45b0d7290868
Created attachment 8609011 [details] [diff] [review]
Mark nsNodeWeakReference::mNode as MOZ_NON_OWNING_REF
Blocks: 1114683
Attachment #8609011 - Flags: review?(jst)
Attachment #8609011 - Flags: review?(jst) → review?(ehsan)

Comment 2

2 years ago
Comment on attachment 8609011 [details] [diff] [review]
Mark nsNodeWeakReference::mNode as MOZ_NON_OWNING_REF

Review of attachment 8609011 [details] [diff] [review]:
-----------------------------------------------------------------

Olli is a better reviewer for this one.
Attachment #8609011 - Flags: review?(ehsan) → review?(bugs)

Comment 3

2 years ago
Comment on attachment 8609011 [details] [diff] [review]
Mark nsNodeWeakReference::mNode as MOZ_NON_OWNING_REF

Yes, this is the whole point of the weakref thing.
Attachment #8609011 - Flags: review?(bugs) → review+
Assignee: nobody → michael
Keywords: checkin-needed

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2a8c2a5878b
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f2a8c2a5878b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.