Closed Bug 1167392 Opened 6 years ago Closed 5 years ago

Change nsFrameMessageManager::mParentManager to a smart pointer

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file, 1 obsolete file)

Change nsFrameMessageManager::mParentManager to a smart pointer
2.71 KB, patch
Details | Diff | Splinter Review
Attachment #8609013 - Flags: review?(jst)
Attachment #8609013 - Flags: review?(jst) → review?(ehsan)
Attachment #8609013 - Flags: review?(ehsan) → review+
Assignee: nobody → michael
Keywords: checkin-needed
failed to apply:

1 out of 1 hunks FAILED -- saving rejects to file dom/base/nsFrameMessageManager.cpp.rej
patching file dom/base/nsFrameMessageManager.h
Hunk #1 FAILED at 317
1 out of 1 hunks FAILED -- saving rejects to file dom/base/nsFrameMessageManager.h.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Change-nsFrameMessageManagermParentManager-to-a-sm.patch

could you take a look, thanks!
Flags: needinfo?(michael)
Keywords: checkin-needed
Rebased onto my local copy of central. Hopefully it applies cleanly now.
Attachment #8609013 - Attachment is obsolete: true
Flags: needinfo?(michael)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/338fcfa6c876
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.