Tab Queue should ignore Sync notifications

RESOLVED FIXED in Firefox 42

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Paul [pwd], Assigned: mhaigh)

Tracking

Trunk
Firefox 42
All
Android
Points:
---

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150513191204

Steps to reproduce:

If you send a tab to Fennec from another device via Sync, it should be ignored by the Tab Queue upon being tapped. It's redundant to tap a notification only to then need to tap another notification (even tapping the toast is a nuisance). Sent tabs should always open directly in the browser.
(Reporter)

Updated

3 years ago
OS: Unspecified → Android
Hardware: Unspecified → All
Flags: needinfo?(mhaigh)
(Assignee)

Comment 1

2 years ago
Created attachment 8626936 [details] [diff] [review]
Tab Queue should ignore Sync notifications

I've added a flag to all sync notifications which will ensure the Tab Queue directly opens these urls.
Flags: needinfo?(mhaigh)
Attachment #8626936 - Flags: review?(michael.l.comella)
(Assignee)

Updated

2 years ago
Assignee: nobody → mhaigh
Comment on attachment 8626936 [details] [diff] [review]
Tab Queue should ignore Sync notifications

Review of attachment 8626936 [details] [diff] [review]:
-----------------------------------------------------------------

I'm unfamiliar with CommandProcessor but this looks about right. :)
Attachment #8626936 - Flags: review?(michael.l.comella) → review+
(Assignee)

Comment 3

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fee9f5658cb9
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/66a2faddf3c3
https://hg.mozilla.org/mozilla-central/rev/66a2faddf3c3
Status: UNCONFIRMED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.