Closed Bug 1167394 Opened 5 years ago Closed 5 years ago

Tab Queue should ignore Sync notifications

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: pwd.mozilla, Assigned: mhaigh)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150513191204

Steps to reproduce:

If you send a tab to Fennec from another device via Sync, it should be ignored by the Tab Queue upon being tapped. It's redundant to tap a notification only to then need to tap another notification (even tapping the toast is a nuisance). Sent tabs should always open directly in the browser.
OS: Unspecified → Android
Hardware: Unspecified → All
Flags: needinfo?(mhaigh)
I've added a flag to all sync notifications which will ensure the Tab Queue directly opens these urls.
Flags: needinfo?(mhaigh)
Attachment #8626936 - Flags: review?(michael.l.comella)
Assignee: nobody → mhaigh
Comment on attachment 8626936 [details] [diff] [review]
Tab Queue should ignore Sync notifications

Review of attachment 8626936 [details] [diff] [review]:
-----------------------------------------------------------------

I'm unfamiliar with CommandProcessor but this looks about right. :)
Attachment #8626936 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/66a2faddf3c3
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.