1167394 - Tab Queue should ignore Sync notifications

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150513191204

Steps to reproduce:

If you send a tab to Fennec from another device via Sync, it should be ignored by the Tab Queue upon being tapped. It's redundant to tap a notification only to then need to tap another notification (even tapping the toast is a nuisance). Sent tabs should always open directly in the browser.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Tab Queue should ignore Sync notifications

I've added a flag to all sync notifications which will ensure the Tab Queue directly opens these urls.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8626936 [details] [diff] [review]
Tab Queue should ignore Sync notifications

Review of attachment 8626936 [details] [diff] [review]:
-----------------------------------------------------------------

I'm unfamiliar with CommandProcessor but this looks about right. :)

Comment 3

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fee9f5658cb9

Comment 4

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/66a2faddf3c3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66a2faddf3c3