1167396 - Make ProtocolCloneContext::mContentParent a smart pointer

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b02893df5ee8

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make ProtocolCloneContext::mContentParent a smart pointer

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8609015 [details] [diff] [review]
Make ProtocolCloneContext::mContentParent a smart pointer

Review of attachment 8609015 [details] [diff] [review]:
-----------------------------------------------------------------

This is probably not needed since ProtocolCloneContext should only be used on the stack I think. But it probably can't hurt.

::: ipc/glue/ProtocolUtils.cpp
@@ +25,5 @@
>  
>  namespace mozilla {
>  namespace ipc {
>  
> +ProtocolCloneContext::ProtocolCloneContext() : mContentParent(nullptr)

Nit: Smart pointers don't need to be initialized to null.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make ProtocolCloneContext::mContentParent a smart pointer

Removed the unnecessary initialization of mContentParent to nullptr

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8609397 [details] [diff] [review]
Make ProtocolCloneContext::mContentParent a smart pointer

Review of attachment 8609397 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: ipc/glue/ProtocolUtils.cpp
@@ +25,5 @@
>  
>  namespace mozilla {
>  namespace ipc {
>  
> +ProtocolCloneContext::ProtocolCloneContext() : mNeckoParent(nullptr)

Nit: Initializer list on its own line please, e.g.:

  ProtocolCloneContext::ProtocolCloneContext()
    : mNeckoParent(nullptr)

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make ProtocolCloneContext::mContentParent a smart pointer

Move initializer list to it's own line

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0db3b7dbcdf6

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0db3b7dbcdf6