Install testing modules in all mochitest suites

RESOLVED FIXED in Firefox 41

Status

Testing
Mochitest
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

unspecified
mozilla41
Points:
---

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently modules like ContentTaskUtils.jsm are only installed in browser-chrome tests. We should install them in all of the suites.
(Assignee)

Comment 1

3 years ago
Created attachment 8609033 [details] [diff] [review]
patch v1

I *think* that we always register the specialpowers extension, though I can't acutally find the makefile/moz.build file that is responsible for doing so.
Attachment #8609033 - Flags: review?(ted)
Comment on attachment 8609033 [details] [diff] [review]
patch v1

Review of attachment 8609033 [details] [diff] [review]:
-----------------------------------------------------------------

I was judging by the comment here guessing that we wouldn't hit this code in chrome/browser-chrome tests:
https://dxr.mozilla.org/mozilla-central/source/testing/specialpowers/components/SpecialPowersObserver.js#23

...but it might be a lie. In any event, mochitest-chrome/browser-chrome would blow up pretty quickly if this doesn't work, so a Try push should prove it out.
Attachment #8609033 - Flags: review?(ted) → review+
(Assignee)

Comment 4

3 years ago
I got worried when I saw your comment, but I had actually checked locally with a couple of browser-chrome tests to make sure they still worked. This is good to go.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f886fbfcd550
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.