Closed
Bug 1167412
Opened 9 years ago
Closed 9 years ago
Install testing modules in all mochitest suites
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
Attachments
(1 file)
2.99 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently modules like ContentTaskUtils.jsm are only installed in browser-chrome tests. We should install them in all of the suites.
Assignee | ||
Comment 1•9 years ago
|
||
I *think* that we always register the specialpowers extension, though I can't acutally find the makefile/moz.build file that is responsible for doing so.
Attachment #8609033 -
Flags: review?(ted)
Comment 2•9 years ago
|
||
Comment on attachment 8609033 [details] [diff] [review] patch v1 Review of attachment 8609033 [details] [diff] [review]: ----------------------------------------------------------------- I was judging by the comment here guessing that we wouldn't hit this code in chrome/browser-chrome tests: https://dxr.mozilla.org/mozilla-central/source/testing/specialpowers/components/SpecialPowersObserver.js#23 ...but it might be a lie. In any event, mochitest-chrome/browser-chrome would blow up pretty quickly if this doesn't work, so a Try push should prove it out.
Attachment #8609033 -
Flags: review?(ted) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6849e6a96f4
Assignee | ||
Comment 4•9 years ago
|
||
I got worried when I saw your comment, but I had actually checked locally with a couple of browser-chrome tests to make sure they still worked. This is good to go.
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f886fbfcd550
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•