1167455 - [Aries][Window Mgmt] When user is trying to add a picture to contact from camera the picture selection menu flickers into view

Status: RESOLVED DUPLICATE of bug 1171201

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When opening camera from contacts app to add a picture to a contact, the menu for choosing source of picture reappears and flickers in and out of view at odd intervals blocking the viewfinder of the camera.

Repro Steps:
1) Update a Xperia Z3 Compact (B2G)
 to 20150516173908
2) Launch contacts
3) Tap existing contact and select edit
4) Press add picture button and select camera as source

Actual:
Source select screen reappears over viewfinder and flickers in and out of view.

Expected:
After source select screen is dismissed, it does not reappear.

Environmental Variables:
Device: Xperia Z3 Compact (B2G)
 3.0
Build ID: 20150516173908
Gaia: 4c0f36e9dfe017bf2a698d416a57c8156b43383d
Gecko: 2f6ea66057fe
Gonk: Could not pull gonk.  Did you shallow Flash?
Version: 41.0a1 (3.0)
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat
Youtube link: http://youtu.be/e2P8_JeiNaI

Comment 1

[Brogan Zumwalt [Inactive]]

Issue does NOT reproduce on Flame 3.0

After source select screen is dismissed, it does not reappear. Camera viewfinder is unobstructed.

Device: Flame 3.0
Build ID: 20150521010203
Gaia: 5a7f87b1505ba89b586372cbbbe9507d1016c40c
Gecko: b9424d63fe35
Version: 41.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 2

[Gregor Wagner [:gwagner]]

Evelyn, does your team support the Z3C yet?

Comment 3

[Evelyn Hung]

I have never seen one... :(

Comment 4

[Gregor Wagner [:gwagner]]

Candice, whats the plan with device specific z3c bugs?

Comment 5

[Candice Serran (:cserran)]

(In reply to Gregor Wagner [:gwagner] from comment #4)
> Candice, whats the plan with device specific z3c bugs?

Jean or Doug, I saw there's a triage scheduled for spark bugs. I'm not sure where this device bug falls in that? Can you respond to Gregor's question please?

Comment 6

[Doug Sherk (:drs) (inactive)]

App leads will be getting Z3C devices to test with. We can also send out more as needed.

Evelyn, would it help if we sent you one or more? There might also be some in Taiwan already.

This actually seems like it might be a graphics issue, and not window management. Andrew, Alex, any thoughts on that?

Comment 7

[:gerard-majax]

No.

Comment 8

[Doug Sherk (:drs) (inactive)]

Speaking with Alex offline, he said that this wasn't an issue for him ~10 days ago on a Z3C, so I think a regression window would be useful here.

Comment 9

[:gerard-majax]

Just to be 100% clear: I use pick from Messages for MMS, and on my dogfooding build which is now ~10 days old, I have never spotted the issue. I do see it on a build from yesterday on my Z3, both in Messages and in Contacts. So it might just be Gecko that regressed in the meantime.

Comment 10

[:gerard-majax]

And I don't see it on my other Z3 Compact (more recent, build from today).

Gecko on Z3: a9bac08932d5a6fe5993b750bef70d489061dc6a
Gecko on Z3 Compact: 547f78dff1fa62c03f694ffcb81d95318f808260

Comment 11

[:gerard-majax]

Brogan, you report the issue on a Z3c build and notice that it does not reproduce on a build for Flame which is one week ahead in time ... I don't think it's enough to say it's specific to Z3c.

Comment 12

[Brogan Zumwalt [Inactive]]

Unable to reproduce issue as reported on latest build, but I can reproduce same flickering if I press the home button after step 4. 

Video of issue: http://youtu.be/o5kP53E7CLA

Apologies for the initial build date disparity, the Z3 build I was testing was the one I was instructed to test by Mozilla.

Device: Xperia Z3 Compact (B2G) 3.0
Build ID: 20150526220312
Gaia: b168b4e2b04ecc2c0a6dcd591679d7694128fb32
Gecko: cafc8056bea143c379643eb9d7c502cc9a2cac25
Version: 41.0a1 (3.0)
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 13

[:gerard-majax]

Looks like I do reproduce it when tapping the home button too, on Z3 Compact that has the recent Gecko/Gaia. I also confirm I don't reproduce this on my Z3 Compact with a much older Gecko.

Z3c OK:
 - Gecko 3b641432c4f0559bd53b8418851708fe63394395
 - Gaia 600fd8249960b8256af9de67d9171025bb9a3ff3

Z3c NOK:
 - Gecko 547f78dff1fa62c03f694ffcb81d95318f808260
 - Gaia 05380df3158fa39e1dde1687c0bf11a71f8c6868

Comment 14

[:gerard-majax]

Funny, there is "5ae5f04 Bug 1166595 - Blur the activity opener before opening activity window" within the range of gaia.

Comment 15

[:gerard-majax]

Bisecting on Gaia, and for now I have been able to type "git bisect bad" and "git bisect good". So at least there's a gaia change that triggers this ...

Comment 16

[:gerard-majax]

So, it took a while because the result of bisect seemed strange to me, but it's 100% the same and reverting this one only on top of master also gets the current issue fixed.

> cfc9d457167048c05b739f66f3a8fdbc4e00684a is the first bad commit
> commit cfc9d457167048c05b739f66f3a8fdbc4e00684a
> Author: Kai-Zhen Li <[e-mail]>
> Date:   Wed Dec 31 12:10:41 2014 +0800
>
>    Bug 1119671 - Update Myanmar keyboard layouts and add imes for it.
>
> :040000 040000 d831c1ac3470e6bf1189c6b5159b4b3d12d3efc3 f064de202b56de1cac39d708d4839b0121a29974 M	apps

Kai-Zhen, it's very strange that your patch triggers this. I suspect you have no idea why :)

Comment 17

[:gerard-majax]

Vivien told me that "we do funny things with the keyboard and activity window"

Comment 18

[Kai-Zhen Li [:seinlin][:kli]]

Yes, it is really strange and  I don't know why your bisect result blames my commit.

But I can't reproduce this issue on my today aries-kk build.

gaia: 4b20609d3f69f08d5f438a8471ccd2b8c4e78917

Comment 19

[:gerard-majax]

(In reply to Kai-Zhen Li [:kli][:seinlin] from comment #18)
> Yes, it is really strange and  I don't know why your bisect result blames my
> commit.
> 
> But I can't reproduce this issue on my today aries-kk build.
> 
> gaia: 4b20609d3f69f08d5f438a8471ccd2b8c4e78917

Strange. Can you at least reproduce on the range where we do?

Comment 20

[:gerard-majax]

Testing on a build from a couple of minutes ago on Z3 Compact, I still see the issue, but only on the first time I do the STR. after I'm unable to see it again.

Comment 21

[Jean Gong :jgong]

[Blocking Requested - why for this release]:

Comment 22

[Jean Gong :jgong]

Naoki, can you try to reproduce on the latest build to see if it still happens.

Comment 23

[Jean Gong :jgong]

Naoki, can you try to reproduce on the latest build to see if it still happens.

Comment 24

[:gerard-majax]

FYI this is still present and I reproduced this on a fresh Z3 build with a brand new profile when I had the dialog for Geolocation. I just launched Camera app for the first time on this profile.

Comment 25

[Pi Wei Cheng [:piwei] (inactive)]

The issue described and showcased on comment 12 is still reproducible on today's Aries build. The picture selection menu flickers into view for a very brief moment after tapping Home.

Device: Xperia Z3 Compact (B2G) 3.0
BuildID: 20150604140701
Gaia: dbf8e12660af79aa118ad1c32b2efc99f9a79c7b
Gecko: 5b4c240e1a36
Version: 41.0a1 (3.0)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

Comment 26

[:gerard-majax]

Probably related to this bug, today I have seen a strange behavior: somehow, after using Camera for taking pictures I have had the Camera app layout (buttons but not the video preview) throughout the user interface: lockscreen, homescreen at least.

Comment 27

[:gerard-majax]

(In reply to Pi Wei Cheng [:piwei] from comment #25)
> The issue described and showcased on comment 12 is still reproducible on
> today's Aries build. The picture selection menu flickers into view for a
> very brief moment after tapping Home.
> 
> Device: Xperia Z3 Compact (B2G) 3.0
> BuildID: 20150604140701
> Gaia: dbf8e12660af79aa118ad1c32b2efc99f9a79c7b
> Gecko: 5b4c240e1a36
> Version: 41.0a1 (3.0)
> Firmware Version: D5803_23.1.A.1.28_NCB.ftf
> User Agent: Mozilla/5.0 (Mobile; rv:41.0) Gecko/41.0 Firefox/41.0

That being said, I don't know what you are testing exactly, because "D5803_23.1.A.1.28_NCB.ftf" is a L system, while the currently tested stuff should be KK.

Comment 28

[Wilson Page [:wilsonpage]]

Attachment: 2015-06-09 14.37.14.jpg

Comment 29

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Alexandre, they used that version to flash first on lollipop so that they get the Lollipop kernel as you suggested to us before.  Then they flash the kitkat builds.  Otherwise we can't go from kk to lollipop later on easily.  

They are testing as a dogfooder would test.

Comment 30

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Turns out that the kernel will flash back to a kk version so what is stated as Firmware Version: D5803_23.1.A.1.28_NCB.ftf is inaccurate and probably a red herring.

adb shell getprop ro.semc.version.sw_revision
23.0.1.A.5.77

I can reproduce the issue.

Comment 31

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

[Blocking Requested - why for this release]:  renoming for spark?  Seems pretty bad when this occurs.  It interferes with picture taking.

Comment 32

[Sotaro Ikeda [:sotaro]]

I tried to reproduce the problem. But failed to reproduce it until now. From the symptom, it seems dup of Bug 1171201.

Comment 33

[Sotaro Ikeda [:sotaro]]

I could reproduce the symptom by adding the following steps.
- Before the STR in comment 0, take screenshot.
- During camera preview, swip camera app view a little bit from right to left.

Comment 34

[Sotaro Ikeda [:sotaro]]

I confirmed that this bug is dup of Bug 1171201. By applying the patch the problem was fixed on aries.

Comment 35

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #33)
> I could reproduce the symptom by adding the following steps.
> - Before the STR in comment 0, take screenshot.

It add a notification line to top of screen.