Closed
Bug 1167474
Opened 9 years ago
Closed 9 years ago
Remove ELFHACK_BUILD hack
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox41 fixed)
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
2.28 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
It used to be necessary because of how elfhack was built in the past, but it happens to be unnecessary nowadays.
Assignee: nobody → mh+mozilla
Attachment #8609127 -
Flags: review?(mshal)
Comment 2•9 years ago
|
||
Comment on attachment 8609127 [details] [diff] [review] Remove ELFHACK_BUILD hack >- * during the export tier. Also, disable this when building assembly files too. >+#if !defined(__ASSEMBLER__) Since we still have !defined(__ASSEMBLER__), maybe keep the last part of the comment? Though it doesn't really explain much, so meh...
Attachment #8609127 -
Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/0ecd4281ab79
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•