Closed Bug 1167494 Opened 5 years ago Closed 4 years ago
Build error with --disable-[content-]sandbox: GMPLoader
.h trying to include missing mozilla/Sandbox .h
Building with both --disable-sandbox and --disable-content-sandbox gives the following error: In file included from mozilla-central/toolkit/xre/nsEmbedFunctions.cpp:74: In file included from ../../dist/include/GMPProcessChild.h:10: In file included from ../../dist/include/GMPChild.h:12: ../../dist/include/GMPLoader.h:14:10: fatal error: 'mozilla/Sandbox.h' file not found #include "mozilla/Sandbox.h" ^ (Not sure which one of --disable-sandbox or --disable-content-sandbox is causing this, didn't have time to try both separately)
Steve - looks like this needs some more #ifs.
> Steve - looks like this needs some more #ifs. Yes it does. Here's a fix. This allows the the tree to be built on OS X with --disable-sandbox. It makes no difference to builds made with --disable-content-sandbox (which already complete without problems on OS X).
Assignee: nobody → smichaud
Attachment #8610889 - Flags: review?(jld)
Comment on attachment 8610889 [details] [diff] [review] Fix Looks good to me.
Attachment #8610889 - Flags: review?(jld) → review+
You need to log in before you can comment on or make changes to this bug.