1167494 - Build error with --disable-[content-]sandbox: GMPLoader.h trying to include missing mozilla/Sandbox.h

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Building with both --disable-sandbox and --disable-content-sandbox gives the following error:
 In file included from mozilla-central/toolkit/xre/nsEmbedFunctions.cpp:74:
 In file included from ../../dist/include/GMPProcessChild.h:10:
 In file included from ../../dist/include/GMPChild.h:12:
 ../../dist/include/GMPLoader.h:14:10: fatal error: 'mozilla/Sandbox.h' file not found
 #include "mozilla/Sandbox.h"
          ^

(Not sure which one of --disable-sandbox or --disable-content-sandbox is causing this, didn't have time to try both separately)

Comment 1

[Bob Owen (:bobowen)]

Steve - looks like this needs some more #ifs.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix

> Steve - looks like this needs some more #ifs.

Yes it does.  Here's a fix.

This allows the the tree to be built on OS X with --disable-sandbox.  It makes no difference to builds made with --disable-content-sandbox (which already complete without problems on OS X).

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8610889 [details] [diff] [review]
Fix

Looks good to me.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bd0ff05cdb9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3bd0ff05cdb9