Closed
Bug 1167505
Opened 11 years ago
Closed 11 years ago
Remove heap related functions from nsTArray
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | affected |
People
(Reporter: birunthan, Assigned: birunthan)
Details
Attachments
(1 file, 1 obsolete file)
|
6.87 KB,
patch
|
Details | Diff | Splinter Review |
These were added in bug 537339, but aren't used any longer.
Attachment #8609203 -
Flags: review?(nfroyd)
Attachment #8609208 -
Flags: review?(nfroyd)
Attachment #8609203 -
Attachment is obsolete: true
Attachment #8609203 -
Flags: review?(nfroyd)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8609208 [details] [diff] [review]
Remove heap related functions from nsTArray
Review of attachment 8609208 [details] [diff] [review]:
-----------------------------------------------------------------
So it looks like we added the heap functions to solve bug 656982, i.e. getting rid of nsTPriorityQueue. But that bug got stalled for various reasons. Why not pick that bug up instead?
Bonus points for modernizing some of the heap functions in nsTArray (e.g. using move construction/assignment) in a followup.
Attachment #8609208 -
Flags: review?(nfroyd)
WONTFIXing based on comment 3.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•