[Stingray][Home] Hide home cards when home is not visible

RESOLVED FIXED

Status

Firefox OS
Gaia::TV
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sungchiu, Assigned: sungchiu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Hide home cards when the home app is not visible to prevent cards flashing before making bubble animation.

Comment 1

2 years ago
Created attachment 8609287 [details] [review]
[gaia] sean2449:Bug-1167525 > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8609287 [details] [review]
[gaia] sean2449:Bug-1167525 > mozilla-b2g:master

Since bubbling animation is made inside a promise, there is a little delay between the time when home is set to visible and bubbling animation is triggered. Although the delay is very short, I can see a instant flash on flame. We have to hide card-list until bubbling animation starts.
Attachment #8609287 - Flags: review?(rexboy)
Comment on attachment 8609287 [details] [review]
[gaia] sean2449:Bug-1167525 > mozilla-b2g:master

r+ with a comment on Github. Please make corresponding changes before landing.
Attachment #8609287 - Flags: review?(rexboy) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
(Assignee)

Comment 6

2 years ago
Commit: https://github.com/sean2449/gaia/commit/65c02398e8b020227e12e5a01f561ffca643454f
Gaia-try (all green): https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=65c02398e8b020227e12e5a01f561ffca643454f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.