Closed Bug 1167525 Opened 9 years ago Closed 9 years ago

[Stingray][Home] Hide home cards when home is not visible

Categories

(Firefox OS Graveyard :: Gaia::TV, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: suchiu, Assigned: suchiu)

Details

Attachments

(1 file)

[gaia] sean2449:Bug-1167525 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review 
Hide home cards when the home app is not visible to prevent cards flashing before making bubble animation.
Comment on attachment 8609287 [details] [review]
[gaia] sean2449:Bug-1167525 > mozilla-b2g:master

Since bubbling animation is made inside a promise, there is a little delay between the time when home is set to visible and bubbling animation is triggered. Although the delay is very short, I can see a instant flash on flame. We have to hide card-list until bubbling animation starts.
Attachment #8609287 - Flags: review?(rexboy)
Comment on attachment 8609287 [details] [review]
[gaia] sean2449:Bug-1167525 > mozilla-b2g:master

r+ with a comment on Github. Please make corresponding changes before landing.
Attachment #8609287 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: