Closed Bug 1167542 Opened 5 years ago Closed 5 years ago

SpeechSynthesisErrorEvent is not implemented

Categories

(Core :: Web Speech, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: kdavis, Assigned: kdavis)

References

Details

(Whiteboard: [webspeechapi][systemsfe])

Attachments

(1 file, 1 obsolete file)

SpeechSynthesisErrorEvent is not implemented. See WebSpeech API https://dvcs.w3.org/hg/speech-api/raw-file/tip/webspeechapi.html
Whiteboard: [webspeechapi]
Component: DOM → Web Speech
Assignee: nobody → kdavis
Whiteboard: [webspeechapi] → [webspeechapi][systemsfe]
Part 1 of 1 Implemented SpeechSynthesisErrorEvent

This is the part 1 of 1 for this bug.

This patch implements SpeechSynthesisErrorEvent, which for whatever reason
was not implemented.

This patch does not, however, hook up SpeechSynthesisErrorEvent to the rest
of the speech synthesis machine. This will be handled in Bug 1178738 

The try for this patch is running here https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab9e4361acc8
Attachment #8627652 - Flags: review?(bugs)
Comment on attachment 8627652 [details] [diff] [review]
Part 1 of 1 Implemented SpeechSynthesisErrorEvent

IIRC, adding the interface to GENERATED_EVENTS_WEBIDL_FILES should be actually enough, but since other events are also in both lists in moz.build, fine.



(Isn't the code generator for *Event interfaces just super nice ;) )
Attachment #8627652 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8627652 [details] [diff] [review]
> Part 1 of 1 Implemented SpeechSynthesisErrorEvent
> 
> IIRC, adding the interface to GENERATED_EVENTS_WEBIDL_FILES should be
> actually enough, but since other events are also in both lists in moz.build,
> fine.

Ok, good to know.

> (Isn't the code generator for *Event interfaces just super nice ;) )

Yes! A little magic is nice every once in a while.
Part 1 of 1 Implemented SpeechSynthesisErrorEvent

This is the part 1 of 1 for this bug.

This patch implements SpeechSynthesisErrorEvent, which for whatever reason
was not implemented.

This patch does not, however, hook up SpeechSynthesisErrorEvent to the rest
of the speech synthesis machine. This will be handled in Bug 1178738

The interdiff between this patch and the one it obsoletes is

====================================================
--- b/dom/events/test/test_all_synthetic_events.html
+++ b/dom/events/test/test_all_synthetic_events.html
@@ -436,6 +436,8 @@
                                                        },
                                              },
   SpeechSynthesisErrorEvent:                 { create: function (aName, aProps) {
+                                                         aProps.error = "synthesis-unavailable";
+                                                         aProps.utterance = new SpeechSynthesisUtterance("Hello World");
                                                          return new SpeechSynthesisErrorEvent(aName, aProps);
                                                        },
                                              },
====================================================

a changed discussed in Bug 1167541 Comment 7

The try for this patch is running here https://treeherder.mozilla.org/#/jobs?repo=try&revision=233643cc54e9

Note in particular M(7) of the B2G emulator tests is OK.
Attachment #8627652 - Attachment is obsolete: true
Attachment #8628222 - Flags: review?(bugs)
Attachment #8628222 - Flags: review?(bugs) → review+
Depends on: 1167541
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/93dce7afa826
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.