116755 - The document function does not accept a variable as its argument

Status: VERIFIED FIXED

(Core :: XSLT, defect, P3)

Description

[Simon Pepping]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7) Gecko/20011221
BuildID:    2001122108

When the document function is called with a string as its argument it works
fine. When it is called with a variable as its argument, it returns an empty
node set.

Reproducible: Always
Steps to Reproduce:
1.Open bug4.xml in the browser.
2.
3.

Actual Results:  String argument: Number of xml files: 1
Variable: bug4a.xml
Variable as argument: Number of xml files: 0

Expected Results:  String argument: Number of xml files: 1
Variable: bug4a.xml
Variable as argument: Number of xml files: 1

Comment 1

[Simon Pepping]

Attachment: attaching stylesheet for verification, bug4.xsl

Comment 2

[Simon Pepping]

Attachment: xml file for verification: bug4.xml

Comment 3

[Simon Pepping]

Attachment: xml file included by the document function: bug4a.xml

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Neat. The problem is that the variable-value is an RTF, which we currently 
handle as a nodeset. And since the nodes in the RTF nodeset don't really have 
any baseURIs (which could be discussed if they should) the uri "bug4a.xml" 
isn't resolved to the right absolute URL. So the fix is to implement RTFs 
correctly.

There are however plenty of workarounds until that is done. Either make sure 
that you convert the argument to a string (ugly) by doing

document(string($xmlfile))
instead of
document($xmlfile)

or make sure that the variable contains a string instead of a RTF (nice) by 
doing

<xsl:param name="xmlfile" select="'bug4a.xml'"/>
instead of
<xsl:param name="xmlfile">bug4a.xml</xsl:param>

Simon: These are great testcases, but it would be greatly appritiated if you 
follow the guidelines at http://www.mozilla.org/projects/xslt/ when attaching 
testcases. See attachments in bug 88745 for reference.

Comment 5

[Axel Hecht]

Jonas, I'm not really happy with your explanation. We don't have a second 
argument to the document() function, so the baseURI should be taken from the
xsl:value-of node. (The code doesn't do that right for a nodeset, I think)
I can't try that, but if we'd use mDefResolveNode in 
http://lxr.mozilla.org/seamonkey/source/extensions/transformiix/source/xslt/functions/DocumentFunctionCall.cpp#112
that might do the trick

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

If there is only one argument and that argument is a nodeset then the baseURI 
should be taken from the .baseURI of the nodes in that nodeset.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

now that our variable handling is decent we can fix this

Comment 8

[jr]

workarounds noted above didn't help me, but switching from

<xsl:variable name="strlib" select="document(concat($lang, '.xml'))/messages"/>
to
<xsl:variable name="strlib" select="document(concat($lang, '.xml'), /)/messages"/>

fixed it for me.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Note that 

document(concat($lang, '.xml'))

makes the url relative to the XSLT document, whereas

document(concat($lang, '.xml'), /)

makes the url relative to the source document. This is per specification. If
that's not the case please file a separate bug.

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 192072 has been marked as a duplicate of this bug. ***

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This will be fixed with petervs RTF-patch

Comment 12

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Clearing milestone since 1.2beta happened a long time ago.

Comment 13

[Axel Hecht]

fixed by rtf landing

Comment 14

[Axel Hecht]

mass verifying