1167602 - Add custom mozharness configs to TC desktop-builder

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Morgan Phillips [:mrrrgn]]

This will allow us to turn off bb-specific features without having to commit code to two separate locations (in tree and in mh). This will also be very nice for getting rid of the symlink hacks (by overriding config variables).

Comment 1

[Morgan Phillips [:mrrrgn]]

Attachment: configs.diff

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8609377 [details] [diff] [review]
configs.diff

Review of attachment 8609377 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with that change

::: testing/docker/desktop-build/Dockerfile
@@ +6,5 @@
>  ADD             bin /home/worker/bin
>  RUN             chmod +x /home/worker/bin/*
>  
> +# Add custom mozharness configs
> +ADD             configs /home/worker/configs

Can we call these extra_mozharness_configs or something like that?  So many things to configure!!

Comment 3

[Morgan Phillips [:mrrrgn]]

By default, mozharness will try to look in ~/configs :/

Comment 4

[Morgan Phillips [:mrrrgn]]

We can just use subdirectories though

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

OK, configs is cool then.  The comment is good enough.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf4a9671af2c

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/cf4a9671af2c

Comment 8

[Morgan Phillips [:mrrrgn]]

Attachment: disable.sendchange.py

The last patch left out the folder / config itself -- this breaks the image build.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20df1ee9106a

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20df1ee9106a